From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751404AbbCBGcN (ORCPT ); Mon, 2 Mar 2015 01:32:13 -0500 Received: from mail-pd0-f170.google.com ([209.85.192.170]:44631 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbbCBGcK (ORCPT ); Mon, 2 Mar 2015 01:32:10 -0500 Message-ID: <1425277920.21429.0.camel@phoenix> Subject: [PATCH] phy: hix5hd2-sata: Convert to use devm_ioremap_resource From: Axel Lin To: Kishon Vijay Abraham I Cc: Jiancheng Xue , Zhangfei Gao , "linux-kernel@vger.kernel.org" Date: Mon, 02 Mar 2015 14:32:00 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_ioremap_resource() also has sanity check for the res argument which is missed in current code. Signed-off-by: Axel Lin --- drivers/phy/phy-hix5hd2-sata.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/phy/phy-hix5hd2-sata.c b/drivers/phy/phy-hix5hd2-sata.c index 34915b4..798adcf 100644 --- a/drivers/phy/phy-hix5hd2-sata.c +++ b/drivers/phy/phy-hix5hd2-sata.c @@ -147,9 +147,9 @@ static int hix5hd2_sata_phy_probe(struct platform_device *pdev) return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - priv->base = devm_ioremap(dev, res->start, resource_size(res)); - if (!priv->base) - return -ENOMEM; + priv->base = devm_ioremap_resource(dev, res); + if (IS_ERR(priv->base)) + return PTR_ERR(priv->base); priv->peri_ctrl = syscon_regmap_lookup_by_phandle(dev->of_node, "hisilicon,peripheral-syscon"); -- 1.9.1