From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753148AbbCBILF (ORCPT ); Mon, 2 Mar 2015 03:11:05 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:43176 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902AbbCBILB (ORCPT ); Mon, 2 Mar 2015 03:11:01 -0500 Message-ID: <1425283854.16106.0.camel@phoenix> Subject: [PATCH] phy: hix5hd2-sata: Check return value of platform_get_resource From: Axel Lin To: Kishon Vijay Abraham I Cc: Jiancheng Xue , Zhangfei Gao , "linux-kernel@vger.kernel.org" Date: Mon, 02 Mar 2015 16:10:54 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This prevent NULL pointer dereference if res is NULL. Signed-off-by: Axel Lin --- This patch replaces [PATCH] phy: hix5hd2-sata: Convert to use devm_ioremap_resource, as zhangfei pinted out that the memory region is shared with sata controller so devm_request_mem_region would fail. drivers/phy/phy-hix5hd2-sata.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/phy/phy-hix5hd2-sata.c b/drivers/phy/phy-hix5hd2-sata.c index 34915b4..d6b2265 100644 --- a/drivers/phy/phy-hix5hd2-sata.c +++ b/drivers/phy/phy-hix5hd2-sata.c @@ -147,6 +147,9 @@ static int hix5hd2_sata_phy_probe(struct platform_device *pdev) return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; + priv->base = devm_ioremap(dev, res->start, resource_size(res)); if (!priv->base) return -ENOMEM; -- 1.9.1