* [PATCH] Staging: fbtft: fix coding style errors @ 2015-02-28 14:31 Matteo Semenzato 2015-02-28 17:37 ` [PATCH V2] " Matteo Semenzato 2015-03-02 13:35 ` Matteo Semenzato 0 siblings, 2 replies; 7+ messages in thread From: Matteo Semenzato @ 2015-02-28 14:31 UTC (permalink / raw) To: thomas.petazzoni, noralf, gregkh, linux-kernel; +Cc: devel, Matteo Semenzato From: Matteo Semenzato <mattew8898@gmail.com> This patch fixes the following error: space required after that ';' Signed-off-by: Matteo Semenzato <mattew8898@gmail.com> --- drivers/staging/fbtft/fbtft_device.c | 68 ++++++++++++++++++------------------ 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index b9f4c30..23d46fe 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft_device.c @@ -61,7 +61,7 @@ MODULE_PARM_DESC(mode, "SPI mode (override device default)"); static char *gpios; module_param(gpios, charp, 0); MODULE_PARM_DESC(gpios, -"List of gpios. Comma separated with the form: reset:23,dc:24 " \ +"List of gpios. Comma separated with the form: reset:23, dc:24 " \ "(when overriding the default, all gpios must be specified)"); static unsigned fps; @@ -109,7 +109,7 @@ module_param_array(init, int, &init_num, 0); MODULE_PARM_DESC(init, "Init sequence, used with the custom argument"); static unsigned long debug; -module_param(debug, ulong , 0); +module_param(debug, ulong, 0); MODULE_PARM_DESC(debug, "level: 0-7 (the remaining 29 bits is for advanced usage)"); @@ -136,43 +136,43 @@ static void adafruit18_green_tab_set_addr_win(struct fbtft_par *par, "03 1d 07 06 2E 2C 29 2D 2E 2E 37 3F 00 00 02 10" static int hy28b_init_sequence[] = { - -1,0x00e7,0x0010,-1,0x0000,0x0001,-1,0x0001,0x0100,-1,0x0002,0x0700, - -1,0x0003,0x1030,-1,0x0004,0x0000,-1,0x0008,0x0207,-1,0x0009,0x0000, - -1,0x000a,0x0000,-1,0x000c,0x0001,-1,0x000d,0x0000,-1,0x000f,0x0000, - -1,0x0010,0x0000,-1,0x0011,0x0007,-1,0x0012,0x0000,-1,0x0013,0x0000, - -2,50,-1,0x0010,0x1590,-1,0x0011,0x0227,-2,50,-1,0x0012,0x009c,-2,50, - -1,0x0013,0x1900,-1,0x0029,0x0023,-1,0x002b,0x000e,-2,50, - -1,0x0020,0x0000,-1,0x0021,0x0000,-2,50,-1,0x0050,0x0000, - -1,0x0051,0x00ef,-1,0x0052,0x0000,-1,0x0053,0x013f,-1,0x0060,0xa700, - -1,0x0061,0x0001,-1,0x006a,0x0000,-1,0x0080,0x0000,-1,0x0081,0x0000, - -1,0x0082,0x0000,-1,0x0083,0x0000,-1,0x0084,0x0000,-1,0x0085,0x0000, - -1,0x0090,0x0010,-1,0x0092,0x0000,-1,0x0093,0x0003,-1,0x0095,0x0110, - -1,0x0097,0x0000,-1,0x0098,0x0000,-1,0x0007,0x0133,-1,0x0020,0x0000, - -1,0x0021,0x0000,-2,100,-3 }; + -1, 0x00e7, 0x0010, -1, 0x0000, 0x0001, -1, 0x0001, 0x0100, -1, 0x0002, 0x0700, + -1, 0x0003, 0x1030, -1, 0x0004, 0x0000, -1, 0x0008, 0x0207, -1, 0x0009, 0x0000, + -1, 0x000a, 0x0000, -1, 0x000c, 0x0001, -1, 0x000d, 0x0000, -1, 0x000f, 0x0000, + -1, 0x0010, 0x0000, -1, 0x0011, 0x0007, -1, 0x0012, 0x0000, -1, 0x0013, 0x0000, + -2, 50, -1, 0x0010, 0x1590, -1, 0x0011, 0x0227, -2, 50, -1, 0x0012, 0x009c, -2, 50, + -1, 0x0013, 0x1900, -1, 0x0029, 0x0023, -1, 0x002b, 0x000e, -2, 50, + -1, 0x0020, 0x0000, -1, 0x0021, 0x0000, -2, 50, -1, 0x0050, 0x0000, + -1, 0x0051, 0x00ef, -1, 0x0052, 0x0000, -1, 0x0053, 0x013f, -1, 0x0060, 0xa700, + -1, 0x0061, 0x0001, -1, 0x006a, 0x0000, -1, 0x0080, 0x0000, -1, 0x0081, 0x0000, + -1, 0x0082, 0x0000, -1, 0x0083, 0x0000, -1, 0x0084, 0x0000, -1, 0x0085, 0x0000, + -1, 0x0090, 0x0010, -1, 0x0092, 0x0000, -1, 0x0093, 0x0003, -1, 0x0095, 0x0110, + -1, 0x0097, 0x0000, -1, 0x0098, 0x0000, -1, 0x0007, 0x0133, -1, 0x0020, 0x0000, + -1, 0x0021, 0x0000, -2, 100, -3 }; #define HY28B_GAMMA \ "04 1F 4 7 7 0 7 7 6 0\n" \ "0F 00 1 7 4 0 0 0 6 7" static int pitft_init_sequence[] = { - -1,0x01,-2,5,-1,0x28,-1,0xEF,0x03,0x80,0x02,-1,0xCF,0x00,0xC1,0x30, - -1,0xED,0x64,0x03,0x12,0x81,-1,0xE8,0x85,0x00,0x78, - -1,0xCB,0x39,0x2C,0x00,0x34,0x02,-1,0xF7,0x20,-1,0xEA,0x00,0x00, - -1,0xC0,0x23,-1,0xC1,0x10,-1,0xC5,0x3e,0x28,-1,0xC7,0x86,-1,0x3A,0x55, - -1,0xB1,0x00,0x18,-1,0xB6,0x08,0x82,0x27,-1,0xF2,0x00,-1,0x26,0x01, - -1,0xE0,0x0F,0x31,0x2B,0x0C,0x0E,0x08,0x4E,0xF1,0x37,0x07,0x10,0x03, - 0x0E,0x09,0x00,-1,0xE1,0x00,0x0E,0x14,0x03,0x11,0x07,0x31,0xC1,0x48, - 0x08,0x0F,0x0C,0x31,0x36,0x0F,-1,0x11,-2,100,-1,0x29,-2,20,-3 }; + -1, 0x01, -2, 5, -1, 0x28, -1, 0xEF, 0x03, 0x80, 0x02, -1, 0xCF, 0x00, 0xC1, 0x30, + -1, 0xED, 0x64, 0x03, 0x12, 0x81, -1, 0xE8, 0x85, 0x00, 0x78, + -1, 0xCB, 0x39, 0x2C, 0x00, 0x34, 0x02, -1, 0xF7, 0x20, -1, 0xEA, 0x00, 0x00, + -1, 0xC0, 0x23, -1, 0xC1, 0x10, -1, 0xC5, 0x3e, 0x28, -1, 0xC7, 0x86, -1, 0x3A, 0x55, + -1, 0xB1, 0x00, 0x18, -1, 0xB6, 0x08, 0x82, 0x27, -1, 0xF2, 0x00, -1, 0x26, 0x01, + -1, 0xE0, 0x0F, 0x31, 0x2B, 0x0C, 0x0E, 0x08, 0x4E, 0xF1, 0x37, 0x07, 0x10, 0x03, + 0x0E, 0x09, 0x00, -1, 0xE1, 0x00, 0x0E, 0x14, 0x03, 0x11, 0x07, 0x31, 0xC1, 0x48, + 0x08, 0x0F, 0x0C, 0x31, 0x36, 0x0F, -1, 0x11, -2, 100, -1, 0x29, -2, 20, -3 }; static int waveshare32b_init_sequence[] = { - -1,0xCB,0x39,0x2C,0x00,0x34,0x02,-1,0xCF,0x00,0xC1,0x30, - -1,0xE8,0x85,0x00,0x78,-1,0xEA,0x00,0x00,-1,0xED,0x64,0x03,0x12,0x81, - -1,0xF7,0x20,-1,0xC0,0x23,-1,0xC1,0x10,-1,0xC5,0x3e,0x28,-1,0xC7,0x86, - -1,0x36,0x28,-1,0x3A,0x55,-1,0xB1,0x00,0x18,-1,0xB6,0x08,0x82,0x27, - -1,0xF2,0x00,-1,0x26,0x01, - -1,0xE0,0x0F,0x31,0x2B,0x0C,0x0E,0x08,0x4E,0xF1,0x37,0x07,0x10,0x03,0x0E,0x09,0x00, - -1,0xE1,0x00,0x0E,0x14,0x03,0x11,0x07,0x31,0xC1,0x48,0x08,0x0F,0x0C,0x31,0x36,0x0F, - -1,0x11,-2,120,-1,0x29,-1,0x2c,-3 }; + -1, 0xCB, 0x39, 0x2C, 0x00, 0x34, 0x02, -1, 0xCF, 0x00, 0xC1, 0x30, + -1, 0xE8, 0x85, 0x00, 0x78, -1, 0xEA, 0x00, 0x00, -1, 0xED, 0x64, 0x03, 0x12, 0x81, + -1, 0xF7, 0x20, -1, 0xC0, 0x23, -1, 0xC1, 0x10, -1, 0xC5, 0x3e, 0x28, -1, 0xC7, 0x86, + -1, 0x36, 0x28, -1, 0x3A, 0x55, -1, 0xB1, 0x00, 0x18, -1, 0xB6, 0x08, 0x82, 0x27, + -1, 0xF2, 0x00, -1, 0x26, 0x01, + -1, 0xE0, 0x0F, 0x31, 0x2B, 0x0C, 0x0E, 0x08, 0x4E, 0xF1, 0x37, 0x07, 0x10, 0x03, 0x0E, 0x09, 0x00, + -1, 0xE1, 0x00, 0x0E, 0x14, 0x03, 0x11, 0x07, 0x31, 0xC1, 0x48, 0x08, 0x0F, 0x0C, 0x31, 0x36, 0x0F, + -1, 0x11, -2, 120, -1, 0x29, -1, 0x2c, -3 }; /* Supported displays in alphabetical order */ static struct fbtft_device_display displays[] = { @@ -486,7 +486,7 @@ static struct fbtft_device_display displays[] = { }, .startbyte = 0b01110000, .bgr = true, - .fps= 50, + .fps = 50, .gpios = (const struct fbtft_gpio []) { { "reset", 25 }, { "led", 18 }, @@ -532,8 +532,8 @@ static struct fbtft_device_display displays[] = { .gpios = (const struct fbtft_gpio []) { /* Wiring for LCD adapter kit */ { "reset", 7 }, - { "dc", 0 }, /* rev 2: 2 */ - { "wr", 1 }, /* rev 2: 3 */ + { "dc", 0 }, /* rev 2: 2 */ + { "wr", 1 }, /* rev 2: 3 */ { "cs", 8 }, { "db00", 17 }, { "db01", 18 }, -- 2.3.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH V2] Staging: fbtft: fix coding style errors 2015-02-28 14:31 [PATCH] Staging: fbtft: fix coding style errors Matteo Semenzato @ 2015-02-28 17:37 ` Matteo Semenzato 2015-03-02 1:17 ` Greg KH 2015-03-02 9:29 ` Dan Carpenter 2015-03-02 13:35 ` Matteo Semenzato 1 sibling, 2 replies; 7+ messages in thread From: Matteo Semenzato @ 2015-02-28 17:37 UTC (permalink / raw) To: thomas.petazzoni, noralf, gregkh; +Cc: devel, linux-kernel, Matteo Semenzato From: Matteo Semenzato <mattew8898@gmail.com> This patch fixes the following error: space required after that ';' Signed-off-by: Matteo Semenzato <mattew8898@gmail.com> --- drivers/staging/fbtft/fbtft_device.c | 145 +++++++++++++++++++++++++++-------- 1 file changed, 111 insertions(+), 34 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index b9f4c30..4c61602 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft_device.c @@ -61,7 +61,7 @@ MODULE_PARM_DESC(mode, "SPI mode (override device default)"); static char *gpios; module_param(gpios, charp, 0); MODULE_PARM_DESC(gpios, -"List of gpios. Comma separated with the form: reset:23,dc:24 " \ +"List of gpios. Comma separated with the form: reset:23, dc:24 " \ "(when overriding the default, all gpios must be specified)"); static unsigned fps; @@ -109,7 +109,7 @@ module_param_array(init, int, &init_num, 0); MODULE_PARM_DESC(init, "Init sequence, used with the custom argument"); static unsigned long debug; -module_param(debug, ulong , 0); +module_param(debug, ulong, 0); MODULE_PARM_DESC(debug, "level: 0-7 (the remaining 29 bits is for advanced usage)"); @@ -136,43 +136,120 @@ static void adafruit18_green_tab_set_addr_win(struct fbtft_par *par, "03 1d 07 06 2E 2C 29 2D 2E 2E 37 3F 00 00 02 10" static int hy28b_init_sequence[] = { - -1,0x00e7,0x0010,-1,0x0000,0x0001,-1,0x0001,0x0100,-1,0x0002,0x0700, - -1,0x0003,0x1030,-1,0x0004,0x0000,-1,0x0008,0x0207,-1,0x0009,0x0000, - -1,0x000a,0x0000,-1,0x000c,0x0001,-1,0x000d,0x0000,-1,0x000f,0x0000, - -1,0x0010,0x0000,-1,0x0011,0x0007,-1,0x0012,0x0000,-1,0x0013,0x0000, - -2,50,-1,0x0010,0x1590,-1,0x0011,0x0227,-2,50,-1,0x0012,0x009c,-2,50, - -1,0x0013,0x1900,-1,0x0029,0x0023,-1,0x002b,0x000e,-2,50, - -1,0x0020,0x0000,-1,0x0021,0x0000,-2,50,-1,0x0050,0x0000, - -1,0x0051,0x00ef,-1,0x0052,0x0000,-1,0x0053,0x013f,-1,0x0060,0xa700, - -1,0x0061,0x0001,-1,0x006a,0x0000,-1,0x0080,0x0000,-1,0x0081,0x0000, - -1,0x0082,0x0000,-1,0x0083,0x0000,-1,0x0084,0x0000,-1,0x0085,0x0000, - -1,0x0090,0x0010,-1,0x0092,0x0000,-1,0x0093,0x0003,-1,0x0095,0x0110, - -1,0x0097,0x0000,-1,0x0098,0x0000,-1,0x0007,0x0133,-1,0x0020,0x0000, - -1,0x0021,0x0000,-2,100,-3 }; + -1, 0x00e7, 0x0010, + -1, 0x0000, 0x0001, + -1, 0x0001, 0x0100, + -1, 0x0002, 0x0700, + -1, 0x0003, 0x1030, + -1, 0x0004, 0x0000, + -1, 0x0008, 0x0207, + -1, 0x0009, 0x0000, + -1, 0x000a, 0x0000, + -1, 0x000c, 0x0001, + -1, 0x000d, 0x0000, + -1, 0x000f, 0x0000, + -1, 0x0010, 0x0000, + -1, 0x0011, 0x0007, + -1, 0x0012, 0x0000, + -1, 0x0013, 0x0000, + -2, 50, + -1, 0x0010, 0x1590, + -1, 0x0011, 0x0227, + -2, 50, + -1, 0x0012, 0x009c, + -2, 50, + -1, 0x0013, 0x1900, + -1, 0x0029, 0x0023, + -1, 0x002b, 0x000e, + -2, 50, + -1, 0x0020, 0x0000, + -1, 0x0021, 0x0000, + -2, 50, + -1, 0x0050, 0x0000, + -1, 0x0051, 0x00ef, + -1, 0x0052, 0x0000, + -1, 0x0053, 0x013f, + -1, 0x0060, 0xa700, + -1, 0x0061, 0x0001, + -1, 0x006a, 0x0000, + -1, 0x0080, 0x0000, + -1, 0x0081, 0x0000, + -1, 0x0082, 0x0000, + -1, 0x0083, 0x0000, + -1, 0x0084, 0x0000, + -1, 0x0085, 0x0000, + -1, 0x0090, 0x0010, + -1, 0x0092, 0x0000, + -1, 0x0093, 0x0003, + -1, 0x0095, 0x0110, + -1, 0x0097, 0x0000, + -1, 0x0098, 0x0000, + -1, 0x0007, 0x0133, + -1, 0x0020, 0x0000, + -1, 0x0021, 0x0000, + -2, 100, + -3 +}; #define HY28B_GAMMA \ "04 1F 4 7 7 0 7 7 6 0\n" \ "0F 00 1 7 4 0 0 0 6 7" static int pitft_init_sequence[] = { - -1,0x01,-2,5,-1,0x28,-1,0xEF,0x03,0x80,0x02,-1,0xCF,0x00,0xC1,0x30, - -1,0xED,0x64,0x03,0x12,0x81,-1,0xE8,0x85,0x00,0x78, - -1,0xCB,0x39,0x2C,0x00,0x34,0x02,-1,0xF7,0x20,-1,0xEA,0x00,0x00, - -1,0xC0,0x23,-1,0xC1,0x10,-1,0xC5,0x3e,0x28,-1,0xC7,0x86,-1,0x3A,0x55, - -1,0xB1,0x00,0x18,-1,0xB6,0x08,0x82,0x27,-1,0xF2,0x00,-1,0x26,0x01, - -1,0xE0,0x0F,0x31,0x2B,0x0C,0x0E,0x08,0x4E,0xF1,0x37,0x07,0x10,0x03, - 0x0E,0x09,0x00,-1,0xE1,0x00,0x0E,0x14,0x03,0x11,0x07,0x31,0xC1,0x48, - 0x08,0x0F,0x0C,0x31,0x36,0x0F,-1,0x11,-2,100,-1,0x29,-2,20,-3 }; + -1, 0x01, + -2, 5, + -1, 0x28, + -1, 0xEF, 0x03, 0x80, 0x02, + -1, 0xCF, 0x00, 0xC1, 0x30, + -1, 0xED, 0x64, 0x03, 0x12, 0x81, + -1, 0xE8, 0x85, 0x00, 0x78, + -1, 0xCB, 0x39, 0x2C, 0x00, 0x34, 0x02, + -1, 0xF7, 0x20, + -1, 0xEA, 0x00, 0x00, + -1, 0xC0, 0x23, + -1, 0xC1, 0x10, + -1, 0xC5, 0x3e, 0x28, + -1, 0xC7, 0x86, + -1, 0x3A, 0x55, + -1, 0xB1, 0x00, 0x18, + -1, 0xB6, 0x08, 0x82, 0x27, + -1, 0xF2, 0x00, + -1, 0x26, 0x01, + -1, 0xE0, 0x0F, 0x31, 0x2B, 0x0C, 0x0E, 0x08, 0x4E, 0xF1, 0x37, 0x07, 0x10, 0x03, 0x0E, 0x09, 0x00, + -1, 0xE1, 0x00, 0x0E, 0x14, 0x03, 0x11, 0x07, 0x31, 0xC1, 0x48, 0x0E, 0x09, 0x00, + -1, 0xE1, 0x00, 0x0E, 0x14, 0x03, 0x11, 0x07, 0x31, 0xC1, 0x48, + 0x08, 0x0F, 0x0C, 0x31, 0x36, 0x0F, + -1, 0x11, + -2, 100, + -1, 0x29, + -2, 20, + -3 +}; static int waveshare32b_init_sequence[] = { - -1,0xCB,0x39,0x2C,0x00,0x34,0x02,-1,0xCF,0x00,0xC1,0x30, - -1,0xE8,0x85,0x00,0x78,-1,0xEA,0x00,0x00,-1,0xED,0x64,0x03,0x12,0x81, - -1,0xF7,0x20,-1,0xC0,0x23,-1,0xC1,0x10,-1,0xC5,0x3e,0x28,-1,0xC7,0x86, - -1,0x36,0x28,-1,0x3A,0x55,-1,0xB1,0x00,0x18,-1,0xB6,0x08,0x82,0x27, - -1,0xF2,0x00,-1,0x26,0x01, - -1,0xE0,0x0F,0x31,0x2B,0x0C,0x0E,0x08,0x4E,0xF1,0x37,0x07,0x10,0x03,0x0E,0x09,0x00, - -1,0xE1,0x00,0x0E,0x14,0x03,0x11,0x07,0x31,0xC1,0x48,0x08,0x0F,0x0C,0x31,0x36,0x0F, - -1,0x11,-2,120,-1,0x29,-1,0x2c,-3 }; + -1, 0xCB, 0x39, 0x2C, 0x00, 0x34, 0x02, + -1, 0xCF, 0x00, 0xC1, 0x30, + -1, 0xE8, 0x85, 0x00, 0x78, + -1, 0xEA, 0x00, 0x00, + -1, 0xED, 0x64, 0x03, 0x12, 0x81, + -1, 0xF7, 0x20, -1, 0xC0, 0x23, + -1, 0xC1, 0x10, + -1, 0xC5, 0x3e, 0x28, + -1, 0xC7, 0x86, + -1, 0x36, 0x28, + -1, 0x3A, 0x55, + -1, 0xB1, 0x00, 0x18, + -1, 0xB6, 0x08, 0x82, 0x27, + -1, 0xF2, 0x00, + -1, 0x26, 0x01, + -1, 0xE0, 0x0F, 0x31, 0x2B, 0x0C, 0x0E, 0x08, 0x4E, 0xF1, 0x37, 0x07, 0x10, 0x03, 0x0E, 0x09, 0x00, + -1, 0xE1, 0x00, 0x0E, 0x14, 0x03, 0x11, 0x07, 0x31, 0xC1, 0x48, 0x08, 0x0F, 0x0C, 0x31, 0x36, 0x0F, + -1, 0x11, + -2, 120, + -1, 0x29, + -1, 0x2c, + -3 +}; /* Supported displays in alphabetical order */ static struct fbtft_device_display displays[] = { @@ -486,7 +563,7 @@ static struct fbtft_device_display displays[] = { }, .startbyte = 0b01110000, .bgr = true, - .fps= 50, + .fps = 50, .gpios = (const struct fbtft_gpio []) { { "reset", 25 }, { "led", 18 }, @@ -532,8 +609,8 @@ static struct fbtft_device_display displays[] = { .gpios = (const struct fbtft_gpio []) { /* Wiring for LCD adapter kit */ { "reset", 7 }, - { "dc", 0 }, /* rev 2: 2 */ - { "wr", 1 }, /* rev 2: 3 */ + { "dc", 0 }, /* rev 2: 2 */ + { "wr", 1 }, /* rev 2: 3 */ { "cs", 8 }, { "db00", 17 }, { "db01", 18 }, -- 2.3.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH V2] Staging: fbtft: fix coding style errors 2015-02-28 17:37 ` [PATCH V2] " Matteo Semenzato @ 2015-03-02 1:17 ` Greg KH 2015-03-02 9:29 ` Dan Carpenter 1 sibling, 0 replies; 7+ messages in thread From: Greg KH @ 2015-03-02 1:17 UTC (permalink / raw) To: Matteo Semenzato; +Cc: thomas.petazzoni, noralf, devel, linux-kernel On Sat, Feb 28, 2015 at 06:37:30PM +0100, Matteo Semenzato wrote: > From: Matteo Semenzato <mattew8898@gmail.com> > > This patch fixes the following error: > space required after that ';' > > Signed-off-by: Matteo Semenzato <mattew8898@gmail.com> > --- > drivers/staging/fbtft/fbtft_device.c | 145 +++++++++++++++++++++++++++-------- > 1 file changed, 111 insertions(+), 34 deletions(-) You have to say what the difference between this one, and v1, otherwise I'll just guess and say it is broken and throw away both of them :( Please fix and resend. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] Staging: fbtft: fix coding style errors 2015-02-28 17:37 ` [PATCH V2] " Matteo Semenzato 2015-03-02 1:17 ` Greg KH @ 2015-03-02 9:29 ` Dan Carpenter 2015-03-02 13:15 ` Matteo Semenzato 1 sibling, 1 reply; 7+ messages in thread From: Dan Carpenter @ 2015-03-02 9:29 UTC (permalink / raw) To: Matteo Semenzato; +Cc: thomas.petazzoni, noralf, gregkh, devel, linux-kernel On Sat, Feb 28, 2015 at 06:37:30PM +0100, Matteo Semenzato wrote: > static int hy28b_init_sequence[] = { > - -1,0x00e7,0x0010,-1,0x0000,0x0001,-1,0x0001,0x0100,-1,0x0002,0x0700, > - -1,0x0003,0x1030,-1,0x0004,0x0000,-1,0x0008,0x0207,-1,0x0009,0x0000, > - -1,0x000a,0x0000,-1,0x000c,0x0001,-1,0x000d,0x0000,-1,0x000f,0x0000, > - -1,0x0010,0x0000,-1,0x0011,0x0007,-1,0x0012,0x0000,-1,0x0013,0x0000, > - -2,50,-1,0x0010,0x1590,-1,0x0011,0x0227,-2,50,-1,0x0012,0x009c,-2,50, > - -1,0x0013,0x1900,-1,0x0029,0x0023,-1,0x002b,0x000e,-2,50, > - -1,0x0020,0x0000,-1,0x0021,0x0000,-2,50,-1,0x0050,0x0000, > - -1,0x0051,0x00ef,-1,0x0052,0x0000,-1,0x0053,0x013f,-1,0x0060,0xa700, > - -1,0x0061,0x0001,-1,0x006a,0x0000,-1,0x0080,0x0000,-1,0x0081,0x0000, > - -1,0x0082,0x0000,-1,0x0083,0x0000,-1,0x0084,0x0000,-1,0x0085,0x0000, > - -1,0x0090,0x0010,-1,0x0092,0x0000,-1,0x0093,0x0003,-1,0x0095,0x0110, > - -1,0x0097,0x0000,-1,0x0098,0x0000,-1,0x0007,0x0133,-1,0x0020,0x0000, > - -1,0x0021,0x0000,-2,100,-3 }; > + -1, 0x00e7, 0x0010, > + -1, 0x0000, 0x0001, > + -1, 0x0001, 0x0100, > + -1, 0x0002, 0x0700, > + -1, 0x0003, 0x1030, > + -1, 0x0004, 0x0000, > + -1, 0x0008, 0x0207, > + -1, 0x0009, 0x0000, > + -1, 0x000a, 0x0000, > + -1, 0x000c, 0x0001, > + -1, 0x000d, 0x0000, > + -1, 0x000f, 0x0000, > + -1, 0x0010, 0x0000, > + -1, 0x0011, 0x0007, > + -1, 0x0012, 0x0000, > + -1, 0x0013, 0x0000, > + -2, 50, > + -1, 0x0010, 0x1590, > + -1, 0x0011, 0x0227, > + -2, 50, > + -1, 0x0012, 0x009c, > + -2, 50, > + -1, 0x0013, 0x1900, > + -1, 0x0029, 0x0023, > + -1, 0x002b, 0x000e, > + -2, 50, > + -1, 0x0020, 0x0000, > + -1, 0x0021, 0x0000, > + -2, 50, > + -1, 0x0050, 0x0000, > + -1, 0x0051, 0x00ef, > + -1, 0x0052, 0x0000, > + -1, 0x0053, 0x013f, > + -1, 0x0060, 0xa700, > + -1, 0x0061, 0x0001, > + -1, 0x006a, 0x0000, > + -1, 0x0080, 0x0000, > + -1, 0x0081, 0x0000, > + -1, 0x0082, 0x0000, > + -1, 0x0083, 0x0000, > + -1, 0x0084, 0x0000, > + -1, 0x0085, 0x0000, > + -1, 0x0090, 0x0010, > + -1, 0x0092, 0x0000, > + -1, 0x0093, 0x0003, > + -1, 0x0095, 0x0110, > + -1, 0x0097, 0x0000, > + -1, 0x0098, 0x0000, > + -1, 0x0007, 0x0133, > + -1, 0x0020, 0x0000, > + -1, 0x0021, 0x0000, > + -2, 100, > + -3 > +}; For some reason you put the line breaks at the negative numbers? Why? regards, dan carpenter ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] Staging: fbtft: fix coding style errors 2015-03-02 9:29 ` Dan Carpenter @ 2015-03-02 13:15 ` Matteo Semenzato 2015-03-02 13:23 ` Dan Carpenter 0 siblings, 1 reply; 7+ messages in thread From: Matteo Semenzato @ 2015-03-02 13:15 UTC (permalink / raw) To: Dan Carpenter; +Cc: linux-kernel@vger.kernel.org Il giorno lun, 02/03/2015 alle 12.29 +0300, Dan Carpenter ha scritto: > On Sat, Feb 28, 2015 at 06:37:30PM +0100, Matteo Semenzato wrote: > > static int hy28b_init_sequence[] = { > > - -1,0x00e7,0x0010,-1,0x0000,0x0001,-1,0x0001,0x0100,-1,0x0002,0x0700, > > - -1,0x0003,0x1030,-1,0x0004,0x0000,-1,0x0008,0x0207,-1,0x0009,0x0000, > > - -1,0x000a,0x0000,-1,0x000c,0x0001,-1,0x000d,0x0000,-1,0x000f,0x0000, > > - -1,0x0010,0x0000,-1,0x0011,0x0007,-1,0x0012,0x0000,-1,0x0013,0x0000, > > - -2,50,-1,0x0010,0x1590,-1,0x0011,0x0227,-2,50,-1,0x0012,0x009c,-2,50, > > - -1,0x0013,0x1900,-1,0x0029,0x0023,-1,0x002b,0x000e,-2,50, > > - -1,0x0020,0x0000,-1,0x0021,0x0000,-2,50,-1,0x0050,0x0000, > > - -1,0x0051,0x00ef,-1,0x0052,0x0000,-1,0x0053,0x013f,-1,0x0060,0xa700, > > - -1,0x0061,0x0001,-1,0x006a,0x0000,-1,0x0080,0x0000,-1,0x0081,0x0000, > > - -1,0x0082,0x0000,-1,0x0083,0x0000,-1,0x0084,0x0000,-1,0x0085,0x0000, > > - -1,0x0090,0x0010,-1,0x0092,0x0000,-1,0x0093,0x0003,-1,0x0095,0x0110, > > - -1,0x0097,0x0000,-1,0x0098,0x0000,-1,0x0007,0x0133,-1,0x0020,0x0000, > > - -1,0x0021,0x0000,-2,100,-3 }; > > + -1, 0x00e7, 0x0010, > > + -1, 0x0000, 0x0001, > > + -1, 0x0001, 0x0100, > > + -1, 0x0002, 0x0700, > > + -1, 0x0003, 0x1030, > > + -1, 0x0004, 0x0000, > > + -1, 0x0008, 0x0207, > > + -1, 0x0009, 0x0000, > > + -1, 0x000a, 0x0000, > > + -1, 0x000c, 0x0001, > > + -1, 0x000d, 0x0000, > > + -1, 0x000f, 0x0000, > > + -1, 0x0010, 0x0000, > > + -1, 0x0011, 0x0007, > > + -1, 0x0012, 0x0000, > > + -1, 0x0013, 0x0000, > > + -2, 50, > > + -1, 0x0010, 0x1590, > > + -1, 0x0011, 0x0227, > > + -2, 50, > > + -1, 0x0012, 0x009c, > > + -2, 50, > > + -1, 0x0013, 0x1900, > > + -1, 0x0029, 0x0023, > > + -1, 0x002b, 0x000e, > > + -2, 50, > > + -1, 0x0020, 0x0000, > > + -1, 0x0021, 0x0000, > > + -2, 50, > > + -1, 0x0050, 0x0000, > > + -1, 0x0051, 0x00ef, > > + -1, 0x0052, 0x0000, > > + -1, 0x0053, 0x013f, > > + -1, 0x0060, 0xa700, > > + -1, 0x0061, 0x0001, > > + -1, 0x006a, 0x0000, > > + -1, 0x0080, 0x0000, > > + -1, 0x0081, 0x0000, > > + -1, 0x0082, 0x0000, > > + -1, 0x0083, 0x0000, > > + -1, 0x0084, 0x0000, > > + -1, 0x0085, 0x0000, > > + -1, 0x0090, 0x0010, > > + -1, 0x0092, 0x0000, > > + -1, 0x0093, 0x0003, > > + -1, 0x0095, 0x0110, > > + -1, 0x0097, 0x0000, > > + -1, 0x0098, 0x0000, > > + -1, 0x0007, 0x0133, > > + -1, 0x0020, 0x0000, > > + -1, 0x0021, 0x0000, > > + -2, 100, > > + -3 > > +}; > > For some reason you put the line breaks at the negative numbers? Why? > > regards, > dan carpenter > -1, -2 and -3 are the init sequence markers: -1: command begin, -2: millisecond delay, -3: end of init sequence ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] Staging: fbtft: fix coding style errors 2015-03-02 13:15 ` Matteo Semenzato @ 2015-03-02 13:23 ` Dan Carpenter 0 siblings, 0 replies; 7+ messages in thread From: Dan Carpenter @ 2015-03-02 13:23 UTC (permalink / raw) To: Matteo Semenzato; +Cc: linux-kernel@vger.kernel.org On Mon, Mar 02, 2015 at 02:15:32PM +0100, Matteo Semenzato wrote: > > > > For some reason you put the line breaks at the negative numbers? Why? > > > > regards, > > dan carpenter > > > -1, -2 and -3 are the init sequence markers: -1: command begin, -2: > millisecond delay, -3: end of init sequence Cool. Put that in the changelog. regards, dan carpenter ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH V2] Staging: fbtft: fix coding style errors 2015-02-28 14:31 [PATCH] Staging: fbtft: fix coding style errors Matteo Semenzato 2015-02-28 17:37 ` [PATCH V2] " Matteo Semenzato @ 2015-03-02 13:35 ` Matteo Semenzato 1 sibling, 0 replies; 7+ messages in thread From: Matteo Semenzato @ 2015-03-02 13:35 UTC (permalink / raw) To: thomas.petazzoni, noralf, gregkh; +Cc: devel, linux-kernel, Matteo Semenzato From: Matteo Semenzato <mattew8898@gmail.com> This patch fixes the following error: space required after that ';' V2: Indented and organized the init sequences. Signed-off-by: Matteo Semenzato <mattew8898@gmail.com> --- drivers/staging/fbtft/fbtft_device.c | 145 +++++++++++++++++++++++++++-------- 1 file changed, 111 insertions(+), 34 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index b9f4c30..4c61602 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft_device.c @@ -61,7 +61,7 @@ MODULE_PARM_DESC(mode, "SPI mode (override device default)"); static char *gpios; module_param(gpios, charp, 0); MODULE_PARM_DESC(gpios, -"List of gpios. Comma separated with the form: reset:23,dc:24 " \ +"List of gpios. Comma separated with the form: reset:23, dc:24 " \ "(when overriding the default, all gpios must be specified)"); static unsigned fps; @@ -109,7 +109,7 @@ module_param_array(init, int, &init_num, 0); MODULE_PARM_DESC(init, "Init sequence, used with the custom argument"); static unsigned long debug; -module_param(debug, ulong , 0); +module_param(debug, ulong, 0); MODULE_PARM_DESC(debug, "level: 0-7 (the remaining 29 bits is for advanced usage)"); @@ -136,43 +136,120 @@ static void adafruit18_green_tab_set_addr_win(struct fbtft_par *par, "03 1d 07 06 2E 2C 29 2D 2E 2E 37 3F 00 00 02 10" static int hy28b_init_sequence[] = { - -1,0x00e7,0x0010,-1,0x0000,0x0001,-1,0x0001,0x0100,-1,0x0002,0x0700, - -1,0x0003,0x1030,-1,0x0004,0x0000,-1,0x0008,0x0207,-1,0x0009,0x0000, - -1,0x000a,0x0000,-1,0x000c,0x0001,-1,0x000d,0x0000,-1,0x000f,0x0000, - -1,0x0010,0x0000,-1,0x0011,0x0007,-1,0x0012,0x0000,-1,0x0013,0x0000, - -2,50,-1,0x0010,0x1590,-1,0x0011,0x0227,-2,50,-1,0x0012,0x009c,-2,50, - -1,0x0013,0x1900,-1,0x0029,0x0023,-1,0x002b,0x000e,-2,50, - -1,0x0020,0x0000,-1,0x0021,0x0000,-2,50,-1,0x0050,0x0000, - -1,0x0051,0x00ef,-1,0x0052,0x0000,-1,0x0053,0x013f,-1,0x0060,0xa700, - -1,0x0061,0x0001,-1,0x006a,0x0000,-1,0x0080,0x0000,-1,0x0081,0x0000, - -1,0x0082,0x0000,-1,0x0083,0x0000,-1,0x0084,0x0000,-1,0x0085,0x0000, - -1,0x0090,0x0010,-1,0x0092,0x0000,-1,0x0093,0x0003,-1,0x0095,0x0110, - -1,0x0097,0x0000,-1,0x0098,0x0000,-1,0x0007,0x0133,-1,0x0020,0x0000, - -1,0x0021,0x0000,-2,100,-3 }; + -1, 0x00e7, 0x0010, + -1, 0x0000, 0x0001, + -1, 0x0001, 0x0100, + -1, 0x0002, 0x0700, + -1, 0x0003, 0x1030, + -1, 0x0004, 0x0000, + -1, 0x0008, 0x0207, + -1, 0x0009, 0x0000, + -1, 0x000a, 0x0000, + -1, 0x000c, 0x0001, + -1, 0x000d, 0x0000, + -1, 0x000f, 0x0000, + -1, 0x0010, 0x0000, + -1, 0x0011, 0x0007, + -1, 0x0012, 0x0000, + -1, 0x0013, 0x0000, + -2, 50, + -1, 0x0010, 0x1590, + -1, 0x0011, 0x0227, + -2, 50, + -1, 0x0012, 0x009c, + -2, 50, + -1, 0x0013, 0x1900, + -1, 0x0029, 0x0023, + -1, 0x002b, 0x000e, + -2, 50, + -1, 0x0020, 0x0000, + -1, 0x0021, 0x0000, + -2, 50, + -1, 0x0050, 0x0000, + -1, 0x0051, 0x00ef, + -1, 0x0052, 0x0000, + -1, 0x0053, 0x013f, + -1, 0x0060, 0xa700, + -1, 0x0061, 0x0001, + -1, 0x006a, 0x0000, + -1, 0x0080, 0x0000, + -1, 0x0081, 0x0000, + -1, 0x0082, 0x0000, + -1, 0x0083, 0x0000, + -1, 0x0084, 0x0000, + -1, 0x0085, 0x0000, + -1, 0x0090, 0x0010, + -1, 0x0092, 0x0000, + -1, 0x0093, 0x0003, + -1, 0x0095, 0x0110, + -1, 0x0097, 0x0000, + -1, 0x0098, 0x0000, + -1, 0x0007, 0x0133, + -1, 0x0020, 0x0000, + -1, 0x0021, 0x0000, + -2, 100, + -3 +}; #define HY28B_GAMMA \ "04 1F 4 7 7 0 7 7 6 0\n" \ "0F 00 1 7 4 0 0 0 6 7" static int pitft_init_sequence[] = { - -1,0x01,-2,5,-1,0x28,-1,0xEF,0x03,0x80,0x02,-1,0xCF,0x00,0xC1,0x30, - -1,0xED,0x64,0x03,0x12,0x81,-1,0xE8,0x85,0x00,0x78, - -1,0xCB,0x39,0x2C,0x00,0x34,0x02,-1,0xF7,0x20,-1,0xEA,0x00,0x00, - -1,0xC0,0x23,-1,0xC1,0x10,-1,0xC5,0x3e,0x28,-1,0xC7,0x86,-1,0x3A,0x55, - -1,0xB1,0x00,0x18,-1,0xB6,0x08,0x82,0x27,-1,0xF2,0x00,-1,0x26,0x01, - -1,0xE0,0x0F,0x31,0x2B,0x0C,0x0E,0x08,0x4E,0xF1,0x37,0x07,0x10,0x03, - 0x0E,0x09,0x00,-1,0xE1,0x00,0x0E,0x14,0x03,0x11,0x07,0x31,0xC1,0x48, - 0x08,0x0F,0x0C,0x31,0x36,0x0F,-1,0x11,-2,100,-1,0x29,-2,20,-3 }; + -1, 0x01, + -2, 5, + -1, 0x28, + -1, 0xEF, 0x03, 0x80, 0x02, + -1, 0xCF, 0x00, 0xC1, 0x30, + -1, 0xED, 0x64, 0x03, 0x12, 0x81, + -1, 0xE8, 0x85, 0x00, 0x78, + -1, 0xCB, 0x39, 0x2C, 0x00, 0x34, 0x02, + -1, 0xF7, 0x20, + -1, 0xEA, 0x00, 0x00, + -1, 0xC0, 0x23, + -1, 0xC1, 0x10, + -1, 0xC5, 0x3e, 0x28, + -1, 0xC7, 0x86, + -1, 0x3A, 0x55, + -1, 0xB1, 0x00, 0x18, + -1, 0xB6, 0x08, 0x82, 0x27, + -1, 0xF2, 0x00, + -1, 0x26, 0x01, + -1, 0xE0, 0x0F, 0x31, 0x2B, 0x0C, 0x0E, 0x08, 0x4E, 0xF1, 0x37, 0x07, 0x10, 0x03, 0x0E, 0x09, 0x00, + -1, 0xE1, 0x00, 0x0E, 0x14, 0x03, 0x11, 0x07, 0x31, 0xC1, 0x48, 0x0E, 0x09, 0x00, + -1, 0xE1, 0x00, 0x0E, 0x14, 0x03, 0x11, 0x07, 0x31, 0xC1, 0x48, + 0x08, 0x0F, 0x0C, 0x31, 0x36, 0x0F, + -1, 0x11, + -2, 100, + -1, 0x29, + -2, 20, + -3 +}; static int waveshare32b_init_sequence[] = { - -1,0xCB,0x39,0x2C,0x00,0x34,0x02,-1,0xCF,0x00,0xC1,0x30, - -1,0xE8,0x85,0x00,0x78,-1,0xEA,0x00,0x00,-1,0xED,0x64,0x03,0x12,0x81, - -1,0xF7,0x20,-1,0xC0,0x23,-1,0xC1,0x10,-1,0xC5,0x3e,0x28,-1,0xC7,0x86, - -1,0x36,0x28,-1,0x3A,0x55,-1,0xB1,0x00,0x18,-1,0xB6,0x08,0x82,0x27, - -1,0xF2,0x00,-1,0x26,0x01, - -1,0xE0,0x0F,0x31,0x2B,0x0C,0x0E,0x08,0x4E,0xF1,0x37,0x07,0x10,0x03,0x0E,0x09,0x00, - -1,0xE1,0x00,0x0E,0x14,0x03,0x11,0x07,0x31,0xC1,0x48,0x08,0x0F,0x0C,0x31,0x36,0x0F, - -1,0x11,-2,120,-1,0x29,-1,0x2c,-3 }; + -1, 0xCB, 0x39, 0x2C, 0x00, 0x34, 0x02, + -1, 0xCF, 0x00, 0xC1, 0x30, + -1, 0xE8, 0x85, 0x00, 0x78, + -1, 0xEA, 0x00, 0x00, + -1, 0xED, 0x64, 0x03, 0x12, 0x81, + -1, 0xF7, 0x20, -1, 0xC0, 0x23, + -1, 0xC1, 0x10, + -1, 0xC5, 0x3e, 0x28, + -1, 0xC7, 0x86, + -1, 0x36, 0x28, + -1, 0x3A, 0x55, + -1, 0xB1, 0x00, 0x18, + -1, 0xB6, 0x08, 0x82, 0x27, + -1, 0xF2, 0x00, + -1, 0x26, 0x01, + -1, 0xE0, 0x0F, 0x31, 0x2B, 0x0C, 0x0E, 0x08, 0x4E, 0xF1, 0x37, 0x07, 0x10, 0x03, 0x0E, 0x09, 0x00, + -1, 0xE1, 0x00, 0x0E, 0x14, 0x03, 0x11, 0x07, 0x31, 0xC1, 0x48, 0x08, 0x0F, 0x0C, 0x31, 0x36, 0x0F, + -1, 0x11, + -2, 120, + -1, 0x29, + -1, 0x2c, + -3 +}; /* Supported displays in alphabetical order */ static struct fbtft_device_display displays[] = { @@ -486,7 +563,7 @@ static struct fbtft_device_display displays[] = { }, .startbyte = 0b01110000, .bgr = true, - .fps= 50, + .fps = 50, .gpios = (const struct fbtft_gpio []) { { "reset", 25 }, { "led", 18 }, @@ -532,8 +609,8 @@ static struct fbtft_device_display displays[] = { .gpios = (const struct fbtft_gpio []) { /* Wiring for LCD adapter kit */ { "reset", 7 }, - { "dc", 0 }, /* rev 2: 2 */ - { "wr", 1 }, /* rev 2: 3 */ + { "dc", 0 }, /* rev 2: 2 */ + { "wr", 1 }, /* rev 2: 3 */ { "cs", 8 }, { "db00", 17 }, { "db01", 18 }, -- 2.3.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-03-02 13:35 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-02-28 14:31 [PATCH] Staging: fbtft: fix coding style errors Matteo Semenzato 2015-02-28 17:37 ` [PATCH V2] " Matteo Semenzato 2015-03-02 1:17 ` Greg KH 2015-03-02 9:29 ` Dan Carpenter 2015-03-02 13:15 ` Matteo Semenzato 2015-03-02 13:23 ` Dan Carpenter 2015-03-02 13:35 ` Matteo Semenzato
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox