From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Matteo Semenzato <mattew8898@gmail.com>,
gregkh@linuxfoundation.org, noralf@tronnes.org,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] Staging: fbtft: fix space errors
Date: Mon, 02 Mar 2015 06:20:48 -0800 [thread overview]
Message-ID: <1425306048.31561.16.camel@perches.com> (raw)
In-Reply-To: <20150302093704.GE5386@mwanda>
On Mon, 2015-03-02 at 12:37 +0300, Dan Carpenter wrote:
> On Sat, Feb 28, 2015 at 06:59:19AM -0800, Joe Perches wrote:
> > If you're really going to change these, please
> > remove the unnecessary \ line continuations
> > indent the blocks properly and group the blocks
> > more intelligibly. Maybe something like;
> >
> > static const int st7735r_init[] = {
> > -1, 0x01,
[]
> > -2, 10,
> > -3
> > };
>
> What's the logic here? Why are we putting the negatives first?
Those are delimiters. see fbtft-core.c:fbtft_init_display().
As far as I understand:
-1, start of block
-2, millisecond delay after block write
-3, end of blocks
Beyond that, I don't much care.
I just prefer intelligible over apparently random.
next prev parent reply other threads:[~2015-03-02 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 14:44 [PATCH] Staging: fbtft: fix space errors Matteo Semenzato
2015-02-28 14:59 ` Joe Perches
2015-03-02 9:37 ` Dan Carpenter
2015-03-02 14:20 ` Joe Perches [this message]
2015-03-02 19:21 ` Andrey Skvortsov
2015-03-02 19:39 ` Noralf Trønnes
2015-02-28 16:04 ` [PATCH V2] " Matteo Semenzato
-- strict thread matches above, loose matches on Subject: below --
2015-02-23 16:24 [PATCH] " Matteo Semenzato
2015-03-02 1:16 ` Greg KH
2015-02-22 8:50 Matteo Semenzato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425306048.31561.16.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattew8898@gmail.com \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox