public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
	Shuah Khan <shuahkh@osg.samsung.com>,
	Prarit Bhargava <prarit@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Richard Cochran <richardcochran@gmail.com>
Subject: [PATCH 02/19] selftests/timers: Quiet warning due to lack of return check on brk
Date: Mon,  2 Mar 2015 13:09:55 -0800	[thread overview]
Message-ID: <1425330612-24280-3-git-send-email-john.stultz@linaro.org> (raw)
In-Reply-To: <1425330612-24280-1-git-send-email-john.stultz@linaro.org>

The posix_timers.c test has a loop that tries to keep it in
kernel space, repeatedly calling brk(). However, it doesn't
check the return value, which causes warnings.

This patch adds a err value which captures the return value
and modifies the test so it will quit if a failure occurs.

Cc: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 tools/testing/selftests/timers/posix_timers.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tools/testing/selftests/timers/posix_timers.c b/tools/testing/selftests/timers/posix_timers.c
index f87d970..5a246a0 100644
--- a/tools/testing/selftests/timers/posix_timers.c
+++ b/tools/testing/selftests/timers/posix_timers.c
@@ -35,10 +35,11 @@ static void user_loop(void)
 static void kernel_loop(void)
 {
 	void *addr = sbrk(0);
+	int err = 0;
 
-	while (!done) {
-		brk(addr + 4096);
-		brk(addr);
+	while (!done && !err) {
+		err = brk(addr + 4096);
+		err |= brk(addr);
 	}
 }
 
@@ -190,8 +191,6 @@ static int check_timer_create(int which)
 
 int main(int argc, char **argv)
 {
-	int err;
-
 	printf("Testing posix timers. False negative may happen on CPU execution \n");
 	printf("based timers if other threads run on the CPU...\n");
 
-- 
1.9.1


  parent reply	other threads:[~2015-03-02 21:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 21:09 [PATCH 00/19 v3] Add timekeeping tests to kernel selftest John Stultz
2015-03-02 21:09 ` [PATCH 01/19] selftests/timers: Cleanup Makefile to make it easier to add future tests John Stultz
2015-03-02 21:09 ` John Stultz [this message]
2015-03-02 21:09 ` [PATCH 03/19] selftests/timers: Add nanosleep test from timetest suite John Stultz
2015-03-02 21:09 ` [PATCH 04/19] selftests/timers: Add inconsistency-check test from timetests John Stultz
2015-03-02 21:09 ` [PATCH 05/19] selftests/timers: Add nsleep-lat test from timetest suite John Stultz
2015-03-02 21:09 ` [PATCH 06/19] selftests/timers: Add clock skew estimation " John Stultz
2015-03-02 21:10 ` [PATCH 07/19] selftests/timers: Add set-timer-lat " John Stultz
2015-03-02 21:10 ` [PATCH 08/19] selftests/timers: Add threaded time inconsistency " John Stultz
2015-03-02 21:10 ` [PATCH 09/19] selftests/timers: Add mqueue latency test from the " John Stultz
2015-03-02 21:10 ` [PATCH 10/19] selftests/timers: Add adjtimex validation test from " John Stultz
2015-03-02 21:10 ` [PATCH 11/19] selftests/timers: Add alarmtimer-suspend test from timetests suite John Stultz
2015-03-02 21:10 ` [PATCH 12/19] selftests/timers: Add change_skew test from timetest suite John Stultz
2015-03-02 21:10 ` [PATCH 13/19] selftests/timers: Add skew_consistency test from the timetests suite John Stultz
2015-03-02 21:10 ` [PATCH 14/19] selftests/timers: Add clocksource-switch test from timetest suite John Stultz
2015-03-02 21:10 ` [PATCH 15/19] selftests/timers: Add leap-a-day " John Stultz
2015-03-02 21:10 ` [PATCH 16/19] selftests/timers: Add leapcrash test from the " John Stultz
2015-03-02 21:10 ` [PATCH 17/19] selftests/timers: Add set-tai " John Stultz
2015-03-02 21:10 ` [PATCH 18/19] selftests/timers: Add set-2038 test from " John Stultz
2015-03-02 21:10 ` [PATCH 19/19] MAINTAINERS: Add selftests/timers to the timekeeping maintainance list John Stultz
2015-03-03 12:14 ` [PATCH 00/19 v3] Add timekeeping tests to kernel selftest Prarit Bhargava
2015-03-11 16:43 ` Shuah Khan
2015-03-11 16:53   ` John Stultz
2015-03-11 17:04     ` Shuah Khan
2015-03-11 17:10       ` John Stultz
  -- strict thread matches above, loose matches on Subject: below --
2015-03-12  0:39 [PATCH 00/19 v4] Add timekeeping tests to kernel selftests John Stultz
2015-03-12  0:39 ` [PATCH 02/19] selftests/timers: Quiet warning due to lack of return check on brk John Stultz
2015-02-25 22:32 [RFC][PATCH 00/19] Add timekeeping tests to kernel selftest John Stultz
2015-02-25 22:32 ` [PATCH 02/19] selftests/timers: Quiet warning due to lack of return check on brk John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425330612-24280-3-git-send-email-john.stultz@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=shuahkh@osg.samsung.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox