From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756782AbbCCP7k (ORCPT ); Tue, 3 Mar 2015 10:59:40 -0500 Received: from mga14.intel.com ([192.55.52.115]:14301 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755270AbbCCP7i (ORCPT ); Tue, 3 Mar 2015 10:59:38 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,682,1418112000"; d="scan'208";a="659809323" Message-ID: <1425398374.14897.155.camel@linux.intel.com> Subject: Re: [PATCH v2] serial/8250_dw: use platform_get_irq() instead of platform_get_resource() From: Andy Shevchenko To: Alexey Brodkin Cc: "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Vineet.Gupta1@synopsys.com" , "gregkh@linuxfoundation.org" , "alan@linux.intel.com" Date: Tue, 03 Mar 2015 17:59:34 +0200 In-Reply-To: <1425397657.17965.28.camel@synopsys.com> References: <1425395474-6762-1-git-send-email-abrodkin@synopsys.com> <1425396362.14897.143.camel@linux.intel.com> <1425396820.17965.16.camel@synopsys.com> <1425397427.14897.149.camel@linux.intel.com> <1425397657.17965.28.camel@synopsys.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-03 at 15:47 +0000, Alexey Brodkin wrote: > > > For example it was useful for me when debugging stacked interrupt > > > controllers setup - I got explicitly notified why this particular device > > > failed on probe. > > > > There are so many device drivers which prints similar message that you > > would consider to make a separate patch to platform.c code to do that > > stuff there once for all. > Then we may want to do another massive clean-up because there're lots of > other drivers that have this message in some form :) Yeah, you may do that and it will be (by my opinion) more useful than introducing one more place with the duplicate message. -- Andy Shevchenko Intel Finland Oy