From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757142AbbCCQhk (ORCPT ); Tue, 3 Mar 2015 11:37:40 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:40200 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757097AbbCCQhh convert rfc822-to-8bit (ORCPT ); Tue, 3 Mar 2015 11:37:37 -0500 From: Alexey Brodkin To: "christian.ruppert@alitech.com" CC: "mika.westerberg@linux.intel.com" , "linux-kernel@vger.kernel.org" , "Vineet.Gupta1@synopsys.com" , "wsa@the-dreams.de" , "andriy.shevchenko@linux.intel.com" , "linux-i2c@vger.kernel.org" , "christian.ruppert@abilis.com" Subject: Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER Thread-Topic: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER Thread-Index: AQHQVcabDW0JFlhjCk25ck2c0gJuOJ0K4ckAgAAClAA= Date: Tue, 3 Mar 2015 16:37:31 +0000 Message-ID: <1425400650.17965.53.camel@synopsys.com> References: <1425396456-10633-1-git-send-email-abrodkin@synopsys.com> <54F5E120.3090705@alitech.com> In-Reply-To: <54F5E120.3090705@alitech.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.225.15.34] Content-Type: text/plain; charset="utf-7" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christian, On Tue, 2015-03-03 at 17:28 +-0100, Christian Ruppert wrote: +AD4- On 2015-03-03 16:27, Alexey Brodkin wrote: +AD4- +AD4- There's no point in printing error message if platform+AF8-get+AF8-irq() +AD4- +AD4- returns -EPROBE+AF8-DEFER because probe deferring subsystem already outputs +AD4- +AD4- message in bootlog like this: +AD4- +AD4- ---+AD4-8--- +AD4- +AD4- platform e001d000.i2c: Driver i2c+AF8-designware requests probe deferral +AD4- +AD4- ---+AD4-8--- +AD4- +AD4- +AD4- +AD4- Moreover in case of probe deferral following message may mislead user: +AD4- +AD4- ---+AD4-8--- +AD4- +AD4- i2c+AF8-designware e001d000.i2c: no irq resource? +AD4- +AD4- ---+AD4-8--- +AD4- +AD4- even though it's expected that platform+AF8-get+AF8-irq() may return +AD4- +AD4- -EPROBE+AF8-DEFER. +AD4- +AD4- +AD4- +AD4- irq +AD0- platform+AF8-get+AF8-irq(pdev, 0)+ADs- +AD4- +AD4- if (irq +ADw- 0) +AHs- +AD4- +AD4- - dev+AF8-err(+ACY-pdev-+AD4-dev, +ACI-no irq resource?+AFw-n+ACI-)+ADs- +AD4- +AD4- +- if (irq +ACEAPQ- -EPROBE+AF8-DEFER) +AD4- +AD4- +- dev+AF8-err(+ACY-pdev-+AD4-dev, +ACI-no irq resource?+AFw-n+ACI-)+ADs- +AD4- +AD4- Presented like this I wonder if this merits being a dev+AF8-err at all. +AD4- Wouldn't dev+AF8-dbg be more adequate? This might remove the need for the +AD4- condition and also avoid bothering everyone if something in the platform +AD4- device structures or device tree is not right. +AD4- +AD4- +AD4- return irq+ADs- /+ACo- -ENXIO +ACo-/ +AD4- +AD4- +AH0- We've just had similar discussion related to DW APB UART with Andy here https://lkml.org/lkml/2015/3/3/412 So yes probably we may safely remove error message from here completely. -Alexey