From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757165AbbCCQyb (ORCPT ); Tue, 3 Mar 2015 11:54:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43153 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756670AbbCCQya (ORCPT ); Tue, 3 Mar 2015 11:54:30 -0500 Message-ID: <1425401657.3240.63.camel@deneb.redhat.com> Subject: Re: [PATCH] c6x: kernel: setup: Include "linux/console.h" if both VT and DUMMY_CONSOLE enabled From: Mark Salter To: Chen Gang <762976180@qq.com> Cc: a-jacquiot@ti.com, robh@kernel.org, "linux-c6x-dev@linux-c6x.org" , "linux-kernel@vger.kernel.org" Date: Tue, 03 Mar 2015 11:54:17 -0500 In-Reply-To: <54F2C6D7.4020006@qq.com> References: <54F2C6D7.4020006@qq.com> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-03-01 at 15:59 +0800, Chen Gang wrote: > Or c6x will cause building break for allmodconfig, the related error: > > CC arch/c6x/kernel/setup.o > arch/c6x/kernel/setup.c: In function 'setup_arch': > arch/c6x/kernel/setup.c:433:2: error: 'conswitchp' undeclared (first use in this function) > conswitchp = &dummy_con; > ^ > arch/c6x/kernel/setup.c:433:2: note: each undeclared identifier is reported only once for each function it appears in > arch/c6x/kernel/setup.c:433:16: error: 'dummy_con' undeclared (first use in this function) > conswitchp = &dummy_con; > ^ > > Signed-off-by: Chen Gang > --- > arch/c6x/kernel/setup.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/c6x/kernel/setup.c b/arch/c6x/kernel/setup.c > index 7571288..a5f6e0e 100644 > --- a/arch/c6x/kernel/setup.c > +++ b/arch/c6x/kernel/setup.c > @@ -26,7 +26,9 @@ > #include > #include > #include > - > +#if defined(CONFIG_VT) && defined(CONFIG_DUMMY_CONSOLE) > +#include > +#endif No need for the #ifdefs around the include. I removed them and pulled this into the c6x tree. Thanks! > > #include > #include