From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932490AbbCCTDZ (ORCPT ); Tue, 3 Mar 2015 14:03:25 -0500 Received: from smtprelay0039.hostedemail.com ([216.40.44.39]:39263 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932398AbbCCTDW (ORCPT ); Tue, 3 Mar 2015 14:03:22 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:3873:3874:4321:5007:6261:7576:7903:10004:10400:10481:10848:10967:11026:11232:11473:11658:11914:12043:12438:12517:12519:12740:13069:13161:13229:13311:13357:19900:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: tiger17_3a0f85ffc9d17 X-Filterd-Recvd-Size: 1730 Message-ID: <1425409397.17273.38.camel@perches.com> Subject: Re: [PATCH net-next 13/14] wireless: Use eth__addr instead of memset From: Joe Perches To: David Miller Cc: johannes@sipsolutions.net, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 03 Mar 2015 11:03:17 -0800 In-Reply-To: <20150303.135737.630359651880852880.davem@davemloft.net> References: <0c710456e4875ff00c1a9fcff9378ed15110dcd3.1425354528.git.joe@perches.com> <1425370617.2450.3.camel@sipsolutions.net> <20150303.135737.630359651880852880.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-03 at 13:57 -0500, David Miller wrote: > From: Johannes Berg > Date: Tue, 03 Mar 2015 09:16:57 +0100 > > > Other than that, I guess I'll apply this, but I really wish there was a > > way to distinguish more easily which of these require alignment and > > which don't. > > You can't apply "this" without the dependency patch #1. > > Therefore this should probably all go through my tree. Hey David. The eth__addr functions already exist so 1/14 isn't a dependency. It's just a trivial improvement on existing code with CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS and at least the arm 4.6.3 compiler.