From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Christian Ruppert <christian.ruppert@alitech.com>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
"christian.ruppert@abilis.com" <christian.ruppert@abilis.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"Vineet.Gupta1@synopsys.com" <Vineet.Gupta1@synopsys.com>
Subject: Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER
Date: Tue, 03 Mar 2015 21:34:31 +0200 [thread overview]
Message-ID: <1425411271.14897.159.camel@linux.intel.com> (raw)
In-Reply-To: <20150303191153.GA7862@katana>
On Tue, 2015-03-03 at 20:11 +0100, Wolfram Sang wrote:
> > Yes, I was thinking even about some wrapper on top of platform_get_irq()
> > since it seems there are no messaging done inside platform.c, though
> > devm_* functions usually have it.
>
> When I had a look a few months ago, the situation with devm_* was messy.
> Some rightfully printed errors, some rightfully didn't, some vice versa,
> some the other way around, and some did something else...
>
> For driver authors, it is hard to see/remember which devm function does
> it and which doesn't. IMO a good cleanup will get rid of this mess. I
> started sketching something but especially clks and irqs are basically
> everywhere and so it easily grew out of the fun-time project scale,
> sadly.
Yeah, same for me. I've checked the situation with platform_get_irq()
and estimate the amount of drivers about 300.
That's why I discourage to create another one that needs to be fixed in
the future.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-03-03 19:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 15:27 [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER Alexey Brodkin
2015-03-03 16:28 ` Christian Ruppert
2015-03-03 16:37 ` Alexey Brodkin
2015-03-03 16:50 ` christian.ruppert
2015-03-03 17:21 ` Wolfram Sang
2015-03-03 17:46 ` Christian Ruppert
2015-03-03 19:03 ` Andy Shevchenko
2015-03-03 19:11 ` Wolfram Sang
2015-03-03 19:34 ` Andy Shevchenko [this message]
2015-03-07 0:24 ` Wolfram Sang
2015-03-09 8:29 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425411271.14897.159.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=christian.ruppert@abilis.com \
--cc=christian.ruppert@alitech.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox