From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756514AbbCCTew (ORCPT ); Tue, 3 Mar 2015 14:34:52 -0500 Received: from mga03.intel.com ([134.134.136.65]:55956 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753375AbbCCTeu (ORCPT ); Tue, 3 Mar 2015 14:34:50 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,683,1418112000"; d="scan'208";a="659928580" Message-ID: <1425411271.14897.159.camel@linux.intel.com> Subject: Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER From: Andy Shevchenko To: Wolfram Sang Cc: Christian Ruppert , Alexey Brodkin , "christian.ruppert@abilis.com" , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mika.westerberg@linux.intel.com" , "Vineet.Gupta1@synopsys.com" Date: Tue, 03 Mar 2015 21:34:31 +0200 In-Reply-To: <20150303191153.GA7862@katana> References: <1425396456-10633-1-git-send-email-abrodkin@synopsys.com> <54F5E120.3090705@alitech.com> <1425400650.17965.53.camel@synopsys.com> <20150303172145.GA7076@katana> <54F5F38D.5050309@alitech.com> <1425409412.14897.157.camel@linux.intel.com> <20150303191153.GA7862@katana> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-03 at 20:11 +0100, Wolfram Sang wrote: > > Yes, I was thinking even about some wrapper on top of platform_get_irq() > > since it seems there are no messaging done inside platform.c, though > > devm_* functions usually have it. > > When I had a look a few months ago, the situation with devm_* was messy. > Some rightfully printed errors, some rightfully didn't, some vice versa, > some the other way around, and some did something else... > > For driver authors, it is hard to see/remember which devm function does > it and which doesn't. IMO a good cleanup will get rid of this mess. I > started sketching something but especially clks and irqs are basically > everywhere and so it easily grew out of the fun-time project scale, > sadly. Yeah, same for me. I've checked the situation with platform_get_irq() and estimate the amount of drivers about 300. That's why I discourage to create another one that needs to be fixed in the future. -- Andy Shevchenko Intel Finland Oy