From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757329AbbCCUjr (ORCPT ); Tue, 3 Mar 2015 15:39:47 -0500 Received: from smtprelay0136.hostedemail.com ([216.40.44.136]:41131 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755833AbbCCUjq (ORCPT ); Tue, 3 Mar 2015 15:39:46 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3867:3870:3871:4321:5007:6261:10004:10400:10848:11026:11658:11914:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: waste55_1ad767442da51 X-Filterd-Recvd-Size: 1333 Message-ID: <1425415182.17273.59.camel@perches.com> Subject: Re: [PATCH 1/1 linux-next] xfs: use bool instead of int for new_parent From: Joe Perches To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Dave Chinner , xfs@oss.sgi.com Date: Tue, 03 Mar 2015 12:39:42 -0800 In-Reply-To: <1425410469-26098-1-git-send-email-fabf@skynet.be> References: <1425410469-26098-1-git-send-email-fabf@skynet.be> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-03 at 20:21 +0100, Fabian Frederick wrote: > new_parent is only used in 0/1 context. [] > diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c [] > @@ -2860,7 +2860,7 @@ xfs_rename( > { > xfs_trans_t *tp = NULL; > xfs_mount_t *mp = src_dp->i_mount; > - int new_parent; /* moving to a new dir */ > + bool new_parent; /* moving to a new dir */ > int src_is_directory; /* src_name is a directory */ Could convert src_is_directory to bool too.