From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933215AbbCDMF5 (ORCPT ); Wed, 4 Mar 2015 07:05:57 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49506 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932803AbbCDMFz (ORCPT ); Wed, 4 Mar 2015 07:05:55 -0500 From: Mark Brown To: Javi Merino , Eduardo Valentin , Zhang Rui Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown Date: Wed, 4 Mar 2015 12:05:39 +0000 Message-Id: <1425470739-16651-1-git-send-email-broonie@kernel.org> X-Mailer: git-send-email 2.1.4 X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: [PATCH] thermal: Fix build for !CONFIG_THERMAL X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit ddd4dd8ddf784 (thermal: extend the cooling device API to include power information) added stubs for newly introduced functions when !CONFIG_THERMAL but did not provide names for the parameters which is a syntax error causing build errors in such configurations. Add names to fix the issue. Also remove an extra semicolon from power_actor_set_power() which also breaks the build and declare the functions as static inline to avoid both multiple definitions and sparse warnings. Signed-off-by: Mark Brown --- include/linux/thermal.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/thermal.h b/include/linux/thermal.h index 4fb31db70b6f..48131730187b 100644 --- a/include/linux/thermal.h +++ b/include/linux/thermal.h @@ -405,11 +405,11 @@ void thermal_notify_framework(struct thermal_zone_device *, int); #else static inline bool cdev_is_power_actor(struct thermal_cooling_device *cdev) { return false; } -int power_actor_get_max_power(struct thermal_cooling_device *, +static inline int power_actor_get_max_power(struct thermal_cooling_device *cdev, struct thermal_zone_device *tz, u32 *max_power) { return 0; } -int power_actor_set_power(struct thermal_cooling_device *, - struct thermal_instance *, u32); +static inline int power_actor_set_power(struct thermal_cooling_device *cdev, + struct thermal_instance *instance, u32 power) { return 0; } static inline struct thermal_zone_device *thermal_zone_device_register( const char *type, int trips, int mask, void *devdata, -- 2.1.4