From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932972AbbCDRVW (ORCPT ); Wed, 4 Mar 2015 12:21:22 -0500 Received: from smtprelay0022.hostedemail.com ([216.40.44.22]:59844 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759350AbbCDRVV (ORCPT ); Wed, 4 Mar 2015 12:21:21 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:2828:2911:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:4425:5007:6261:6742:7974:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12663:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: ghost50_6281a9e262e4b X-Filterd-Recvd-Size: 3149 Message-ID: <1425489675.2712.16.camel@perches.com> Subject: Re: [PATCH 4.0-rc1 v17 4/6] printk: Simple implementation for NMI backtracing From: Joe Perches To: Daniel Thompson Cc: Steven Rostedt , Thomas Gleixner , Jason Cooper , Russell King , Will Deacon , Catalin Marinas , Marc Zyngier , Stephen Boyd , John Stultz , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@linaro.org, linaro-kernel@lists.linaro.org, Sumit Semwal , Dirk Behme , Daniel Drake , Dmitry Pervushin , Tim Sander Date: Wed, 04 Mar 2015 09:21:15 -0800 In-Reply-To: <1425486786.2769.25.camel@linaro.org> References: <1422022952-31552-1-git-send-email-daniel.thompson@linaro.org> <1425463974-23568-1-git-send-email-daniel.thompson@linaro.org> <1425463974-23568-5-git-send-email-daniel.thompson@linaro.org> <1425485601.2712.9.camel@perches.com> <20150304112010.338501ab@gandalf.local.home> <1425486786.2769.25.camel@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-04 at 16:33 +0000, Daniel Thompson wrote: > On Wed, 2015-03-04 at 11:20 -0500, Steven Rostedt wrote: > > On Wed, 04 Mar 2015 08:13:21 -0800 > > Joe Perches wrote: > > > > > On Wed, 2015-03-04 at 10:12 +0000, Daniel Thompson wrote: > > > > Currently there is a quite a pile of code sitting in > > > > arch/x86/kernel/apic/hw_nmi.c to support safe all-cpu backtracing from NMI. > > > > The code is inaccessible to backtrace implementations for other > > > > architectures, which is a shame because they would probably like to be > > > > safe too. > > > > > > > > Copy this code into printk. We'll port the x86 NMI backtrace to it in a > > > > later patch. > > > > > > I think this would be better as a separate file > > > rather than increasing the bulk of printk.c > > > > > I agree, as printk already has its own directory. Perhaps a > > "nmi_backtrace.c"? > > I agree on moving the code. However, after Thomas' review I made sure > all the external symbols were prefixed printk_nmi and, as a result of > the same review I started using CONFIG_PRINTK_NMI to enable/disable the > feature). For that reason I'm much more inclined to name it > "printk_nmi.c". Any objections? Steven's suggestion seems more sensible. sed 's/CONFIG_PRINTK_NMI/CONFIG_PRINTK_NMI_BACKTRACE/g' sed 's/printk_nmi/printk_nmib/g' or sed 's/printk_nmi/nmi_backtrace/g' might work well.