From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753921AbbCEBnO (ORCPT ); Wed, 4 Mar 2015 20:43:14 -0500 Received: from mail-pd0-f169.google.com ([209.85.192.169]:33541 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753704AbbCEBnN (ORCPT ); Wed, 4 Mar 2015 20:43:13 -0500 Message-ID: <1425519789.1637.4.camel@phoenix> Subject: [PATCH 1/2] phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof From: Axel Lin To: Kishon Vijay Abraham I Cc: Gabriel FERNANDEZ , "kernel@vger.kernel.org" , Alexandre Torgue Date: Thu, 05 Mar 2015 09:43:09 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Prefer devm_kcalloc over devm_kzalloc with multiply. In additional, use sizeof(phy) is incorrect, fix it. Signed-off-by: Axel Lin --- This patch is on top of below patch: [PATCH 1/2] phy: miphy28lp: Avoid calling of_get_child_count() multiple times drivers/phy/phy-miphy28lp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c index 4fe1755..9334352 100644 --- a/drivers/phy/phy-miphy28lp.c +++ b/drivers/phy/phy-miphy28lp.c @@ -1209,9 +1209,8 @@ static int miphy28lp_probe(struct platform_device *pdev) return -ENOMEM; miphy_dev->nphys = of_get_child_count(np); - miphy_dev->phys = devm_kzalloc(&pdev->dev, - sizeof(phy) * miphy_dev->nphys, - GFP_KERNEL); + miphy_dev->phys = devm_kcalloc(&pdev->dev, miphy_dev->nphys, + sizeof(*miphy_dev->phys), GFP_KERNEL); if (!miphy_dev->phys) return -ENOMEM; -- 1.9.1