From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758013AbbCETNs (ORCPT <rfc822;w@1wt.eu>);
	Thu, 5 Mar 2015 14:13:48 -0500
Received: from cpsmtpb-ews07.kpnxchange.com ([213.75.39.10]:50884 "EHLO
	cpsmtpb-ews07.kpnxchange.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751600AbbCETNq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 5 Mar 2015 14:13:46 -0500
Message-ID: <1425582823.24292.225.camel@x220>
Subject: Re: [PATCH 2/2] mtd: nand: jz4780: driver for NAND devices on
 JZ4780 SoCs
From: Paul Bolle <pebolle@tiscali.nl>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mtd@lists.infradead.org
Date: Thu, 05 Mar 2015 20:13:43 +0100
In-Reply-To: <1425576461-52412-3-git-send-email-Zubair.Kakakhel@imgtec.com>
References: <1425576461-52412-1-git-send-email-Zubair.Kakakhel@imgtec.com>
	 <1425576461-52412-3-git-send-email-Zubair.Kakakhel@imgtec.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 05 Mar 2015 19:13:44.0289 (UTC) FILETIME=[7FA3FD10:01D05778]
X-RcptDomain: vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-03-05 at 17:27 +0000, Zubair Lutfullah Kakakhel wrote:
> --- /dev/null
> +++ b/drivers/mtd/nand/jz4780_bch.c
> @@ -0,0 +1,359 @@
> +/*
> + * JZ4780 BCH controller
> + *
> + * Copyright (c) 2015 Imagination Technologies
> + * Author: Alex Smith <alex@alex-smith.me.uk>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation;  either version 2 of the  License, or (at your
> + * option) any later version.
> + */

This states the license is GPL v2 or later.

> +MODULE_LICENSE("GPL v2");

So you probably want
    MODULE_LICENSE("GPL");

here.

> --- /dev/null
> +++ b/drivers/mtd/nand/jz4780_nand.c
> @@ -0,0 +1,373 @@
> +/*
> + * JZ4780 NAND driver
> + *
> + * Copyright (c) 2015 Imagination Technologies
> + * Author: Alex Smith <alex@alex-smith.me.uk>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation;  either version 2 of the  License, or (at your
> + * option) any later version.
> + */

This states the license is GPL v2 or later.

> +MODULE_LICENSE("GPL V2");

So, again, you probably want
    MODULE_LICENSE("GPL");

here.

Actually "GPL V2" would taint the kernel on module load.

(This all assumes we're talking about two separate modules here. I don't
speak "Makefile" enough to be sure.)


Paul Bolle