From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753937AbbCFRTP (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Mar 2015 12:19:15 -0500
Received: from cantor2.suse.de ([195.135.220.15]:36116 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751053AbbCFRTL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Mar 2015 12:19:11 -0500
Message-ID: <1425662342.19505.41.camel@stgolabs.net>
Subject: Re: sched: softlockups in multi_cpu_stop
From: Davidlohr Bueso <dave@stgolabs.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: Sasha Levin <sasha.levin@oracle.com>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Dave Jones <davej@codemonkey.org.uk>, jason.low2@hp.com,
        Linus Torvalds <torvalds@linux-foundation.org>
Date: Fri, 06 Mar 2015 09:19:02 -0800
In-Reply-To: <20150306123233.GA9972@gmail.com>
References: <54F41516.6060608@oracle.com> <54F98F1F.3080107@oracle.com>
	 <20150306123233.GA9972@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2015-03-06 at 13:32 +0100, Ingo Molnar wrote:
> * Sasha Levin <sasha.levin@oracle.com> wrote:
> 
> > I've bisected this to "locking/rwsem: Check for active lock before bailing on spinning". Relevant parties Cc'ed.
> 
> That would be:
> 
>   1a99367023f6 ("locking/rwsem: Check for active lock before bailing on spinning")
> 
> attached below.

[...]

> diff --git a/kernel/locking/rwsem-xadd.c b/kernel/locking/rwsem-xadd.c
> index 1c0d11e8ce34..e4ad019e23f5 100644
> --- a/kernel/locking/rwsem-xadd.c
> +++ b/kernel/locking/rwsem-xadd.c
> @@ -298,23 +298,30 @@ static inline bool rwsem_try_write_lock_unqueued(struct rw_semaphore *sem)
>  static inline bool rwsem_can_spin_on_owner(struct rw_semaphore *sem)
>  {
>  	struct task_struct *owner;
> -	bool on_cpu = false;
> +	bool ret = true;
>  
>  	if (need_resched())
>  		return false;
>  
>  	rcu_read_lock();
>  	owner = ACCESS_ONCE(sem->owner);
> -	if (owner)
> -		on_cpu = owner->on_cpu;
> -	rcu_read_unlock();
> +	if (!owner) {
> +		long count = ACCESS_ONCE(sem->count);
> +		/*
> +		 * If sem->owner is not set, yet we have just recently entered the
> +		 * slowpath with the lock being active, then there is a possibility
> +		 * reader(s) may have the lock. To be safe, bail spinning in these
> +		 * situations.
> +		 */
> +		if (count & RWSEM_ACTIVE_MASK)
> +			ret = false;
> +		goto done;

Hmmm so the lockup would be due to this (when owner is non-nil the patch
has no effect), telling users to spin instead of sleep -- _except_ for
this condition. And when spinning we're always checking for need_resched
to be safe. So even if this function was completely bogus, we'd end up
needlessly spinning but I'm surprised about the lockup. Maybe coffee
will make things clearer.