From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754756AbbCFRfK (ORCPT ); Fri, 6 Mar 2015 12:35:10 -0500 Received: from smtprelay0082.hostedemail.com ([216.40.44.82]:47967 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751438AbbCFRfH (ORCPT ); Fri, 6 Mar 2015 12:35:07 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:967:968:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2559:2562:2682:2685:2828:2859:2892:2899:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4037:4250:4321:5007:6261:7514:7903:8603:9025:9040:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13095:13161:13229:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: home84_2c4e2e3e13557 X-Filterd-Recvd-Size: 2543 Message-ID: <1425663302.12017.32.camel@perches.com> Subject: Re: [PATCH 1/1] staging: rtl8723au: Remove unnecessary OOM message From: Joe Perches To: Jes Sorensen Cc: Julia Lawall , Quentin Lambert , Larry Finger , Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Fri, 06 Mar 2015 09:35:02 -0800 In-Reply-To: References: <20150306082140.GA9740@sloth> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-03-06 at 11:08 -0500, Jes Sorensen wrote: > Julia Lawall writes: > > On Fri, 6 Mar 2015, Jes Sorensen wrote: > >> Quentin Lambert writes: > >> > This patch reduces the kernel size by removing error messages that duplicate > >> > the normal OOM message. > >> > A simplified version of the semantic patch that finds this problem is as > >> > follows: (http://coccinelle.lip6.fr) > >> This patch removes useful warnings about what allocation failed. The > >> messages removed are NOT duplicate! > > Is it really the case that the information can't be reconstructed from the > > information generated by kmalloc on failure? To my understanding there is > > a stack trace, and from scanning through the changes I see only one change > > per function, so perhaps the stack trace already makes it clear where the > > problem occurred? > It may be possible to backtrack, but this change just makes it harder. > There are tons of real issues to fix in this driver, this patch just > increases the risk of patch conflicts for no real gain. Making the allocation less likely to fail for low memory systems is a gain. The allocation failures themselves are low likelihood events. Determining which specific memory allocation failure occurred has near nil value.