From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755299AbbCFSnR (ORCPT ); Fri, 6 Mar 2015 13:43:17 -0500 Received: from mga01.intel.com ([192.55.52.88]:10397 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755058AbbCFSnO (ORCPT ); Fri, 6 Mar 2015 13:43:14 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,354,1422950400"; d="scan'208";a="695037597" Message-ID: <1425667392.32009.8.camel@theros.lm.intel.com> Subject: Re: [PATCH 5/8] mm: Let sparse_{add,remove}_one_section receive a node_id From: Ross Zwisler To: Boaz Harrosh Cc: Ingo Molnar , x86@kernel.org, linux-kernel , "Roger C. Pao" , Dan Williams , Thomas Gleixner , linux-nvdimm , "H. Peter Anvin" , Matthew Wilcox , Andy Lutomirski , Christoph Hellwig Date: Fri, 06 Mar 2015 11:43:12 -0700 In-Reply-To: <54F844E5.5090500@plexistor.com> References: <54F82CE0.4040502@plexistor.com> <54F830D4.7030205@plexistor.com> <54F844E5.5090500@plexistor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20.rez) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-05 at 13:58 +0200, Boaz Harrosh wrote: > From: Yigal Korman > > Refactored the arguments of sparse_add_one_section / sparse_remove_one_section > to use node id instead of struct zone * - A memory section has no direct > connection to zones, all that was needed from zone was the node id. > > This is for add_persistent_memory that will want a section of pages > allocated but without any zone associated. This is because belonging > to a zone will give the memory to the page allocators, but > persistent_memory belongs to a block device, and is not available for > regular volatile usage. > > Signed-off-by: Yigal Korman > Signed-off-by: Boaz Harrosh > --- > include/linux/memory_hotplug.h | 4 ++-- > mm/memory_hotplug.c | 4 ++-- > mm/sparse.c | 9 +++++---- > 3 files changed, 9 insertions(+), 8 deletions(-) For both of the MM patches in this series (this one, 5/8, and the next one, 6/8), please be sure and CC the MM folks. I know that Dave Hansen had feedback on an earlier version of this patch: https://lkml.org/lkml/2014/9/9/742 We need to make sure that feedback is addressed. Thanks, - Ross