From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756651AbbCFTvI (ORCPT ); Fri, 6 Mar 2015 14:51:08 -0500 Received: from smtprelay0127.hostedemail.com ([216.40.44.127]:60219 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756401AbbCFTvC (ORCPT ); Fri, 6 Mar 2015 14:51:02 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2196:2199:2200:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3871:3872:4321:4385:5007:6119:6261:7903:10004:10400:10848:11026:11232:11657:11658:11914:12043:12438:12517:12519:12555:12740:13019:13069:13095:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: ducks26_42ebce7e3625a X-Filterd-Recvd-Size: 2816 Message-ID: <1425671458.12017.41.camel@perches.com> Subject: Re: [PATCH] bgmac: ratelimit warning messages From: Joe Perches To: Peter Senna Tschudin Cc: davem@davemloft.net, hauke@hauke-m.de, w-lkml@lebenslange-mailadresse.de, zajec5@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 06 Mar 2015 11:50:58 -0800 In-Reply-To: <1425665874-14870-1-git-send-email-peter.senna@gmail.com> References: <1425665874-14870-1-git-send-email-peter.senna@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-03-06 at 19:17 +0100, Peter Senna Tschudin wrote: > On my test environment the troughput of a file transfer drops from > 4.4Mbps to 116Kbps due the number of repeated warning messages. > Adding printk_ratelimit() solves the issue without removing the > warning message. What value is there for this message being emitted more than once? > diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c > @@ -302,7 +302,7 @@ static int bgmac_dma_rx_skb_for_slot(struct bgmac *bgmac, > slot->skb = skb; > slot->dma_addr = dma_addr; > > - if (slot->dma_addr & 0xC0000000) > + if ((slot->dma_addr & 0xC0000000) && printk_ratelimit()) > bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n"); Maybe better as a static function static void check_translate_address(struct bgmac *bgmac, dma_addr_t addr) { static bool printed; if (!printed && (addr & (dma_addr_t)0xC0000000))) printed = true; bgmac_warn(bgmac, etc...); } } [...] check_translate_address(bgmac, slot->dma_addr); > return 0; > @@ -505,7 +505,7 @@ static int bgmac_dma_alloc(struct bgmac *bgmac) > ring->mmio_base); > goto err_dma_free; > } > - if (ring->dma_base & 0xC0000000) > + if ((ring->dma_base & 0xC0000000) && printk_ratelimit()) > bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n"); > > ring->unaligned = bgmac_dma_unaligned(bgmac, ring, > @@ -536,7 +536,7 @@ static int bgmac_dma_alloc(struct bgmac *bgmac) > err = -ENOMEM; > goto err_dma_free; > } > - if (ring->dma_base & 0xC0000000) > + if ((ring->dma_base & 0xC0000000) && printk_ratelimit()) > bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n"); > > ring->unaligned = bgmac_dma_unaligned(bgmac, ring,