From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753030AbbCHRA6 (ORCPT ); Sun, 8 Mar 2015 13:00:58 -0400 Received: from smtprelay0190.hostedemail.com ([216.40.44.190]:33276 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752825AbbCHRA5 (ORCPT ); Sun, 8 Mar 2015 13:00:57 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3868:3873:4321:5007:6261:8957:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12438:12517:12519:12740:13069:13071:13161:13229:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: eyes09_7f23970f8a45 X-Filterd-Recvd-Size: 1823 Message-ID: <1425834052.5898.1.camel@perches.com> Subject: Re: [PATCH v2] staging: rtl8188eu: use %pM specifier instead of passing direct values From: Joe Perches To: Mike Krinkin Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 08 Mar 2015 10:00:52 -0700 In-Reply-To: <1425832962-3305-1-git-send-email-krinkin.m.u@gmail.com> References: <1425832962-3305-1-git-send-email-krinkin.m.u@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-03-08 at 19:42 +0300, Mike Krinkin wrote: > The patch converts code to use %pM specifier instead of pushing > each byte via stack. Hello Mike. > diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c [] > @@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool > memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN); > } > RT_TRACE(_module_hci_hal_init_c_, _drv_notice_, > - ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n", > - eeprom->mac_addr[0], eeprom->mac_addr[1], > - eeprom->mac_addr[2], eeprom->mac_addr[3], > - eeprom->mac_addr[4], eeprom->mac_addr[5])); > + ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n", > + eeprom->mac_addr)); You changed the subject and commit log but not the patch. V3?