From: Joe Perches <joe@perches.com>
To: Lavinia Tache <lavinia.tachee@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [PATCH V2] drivers/base: use tabs where possible in code indentation
Date: Sun, 08 Mar 2015 13:40:57 -0700 [thread overview]
Message-ID: <1425847257.5898.8.camel@perches.com> (raw)
In-Reply-To: <1425846824-7284-1-git-send-email-lavinia.tachee@gmail.com>
On Sun, 2015-03-08 at 22:33 +0200, Lavinia Tache wrote:
> Linux kernel coding style require that tabs should be used instead of
> spaces for code indentation.
> Problem found using checkpatch.pl script.
[]
> diff --git a/drivers/base/soc.c b/drivers/base/soc.c
[]
> @@ -43,8 +43,8 @@ struct device *soc_device_to_device(struct soc_device *soc_dev)
> }
>
> static umode_t soc_attribute_mode(struct kobject *kobj,
> - struct attribute *attr,
> - int index)
> + struct attribute *attr,
> + int index)
It'd be nicer to keep the alignment to the open parenthesis.
prev parent reply other threads:[~2015-03-08 20:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 20:33 [PATCH] [PATCH V2] drivers/base: use tabs where possible in code indentation Lavinia Tache
2015-03-08 20:40 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425847257.5898.8.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=lavinia.tachee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox