From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752794AbbCHUlF (ORCPT ); Sun, 8 Mar 2015 16:41:05 -0400 Received: from smtprelay0183.hostedemail.com ([216.40.44.183]:45484 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752065AbbCHUlB (ORCPT ); Sun, 8 Mar 2015 16:41:01 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:1801:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3872:3874:4321:4605:4823:5007:6261:10004:10400:10848:11026:11232:11658:11914:12296:12438:12517:12519:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: cover03_25c6eae1b9e3b X-Filterd-Recvd-Size: 1502 Message-ID: <1425847257.5898.8.camel@perches.com> Subject: Re: [PATCH] [PATCH V2] drivers/base: use tabs where possible in code indentation From: Joe Perches To: Lavinia Tache Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Date: Sun, 08 Mar 2015 13:40:57 -0700 In-Reply-To: <1425846824-7284-1-git-send-email-lavinia.tachee@gmail.com> References: <1425846824-7284-1-git-send-email-lavinia.tachee@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-03-08 at 22:33 +0200, Lavinia Tache wrote: > Linux kernel coding style require that tabs should be used instead of > spaces for code indentation. > Problem found using checkpatch.pl script. [] > diff --git a/drivers/base/soc.c b/drivers/base/soc.c [] > @@ -43,8 +43,8 @@ struct device *soc_device_to_device(struct soc_device *soc_dev) > } > > static umode_t soc_attribute_mode(struct kobject *kobj, > - struct attribute *attr, > - int index) > + struct attribute *attr, > + int index) It'd be nicer to keep the alignment to the open parenthesis.