From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753116AbbCHUxt (ORCPT ); Sun, 8 Mar 2015 16:53:49 -0400 Received: from smtprelay0133.hostedemail.com ([216.40.44.133]:45087 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751735AbbCHUxp (ORCPT ); Sun, 8 Mar 2015 16:53:45 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3872:3874:4321:4605:5007:6261:7514:10004:10400:10848:11026:11232:11657:11658:11914:12043:12296:12438:12517:12519:12555:12740:13069:13141:13161:13184:13229:13230:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: desk55_352877de5c43 X-Filterd-Recvd-Size: 2658 Message-ID: <1425848020.5898.13.camel@perches.com> Subject: Re: [PATCH 3/3] staging: lustre: space required after that close brace '}' From: Joe Perches To: Alberto Pires de Oliveira Neto Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Date: Sun, 08 Mar 2015 13:53:40 -0700 In-Reply-To: <90200ddcea30fa779b41e5833514a2a66a8862ef.1425845842.git.mrpenguin2005@gmail.com> References: <90200ddcea30fa779b41e5833514a2a66a8862ef.1425845842.git.mrpenguin2005@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-03-08 at 17:43 -0300, Alberto Pires de Oliveira Neto wrote: > This patch fixes checkpatch.pl warning. > WARNING: space required after that close brace '}' > > Signed-off-by: Alberto Pires de Oliveira Neto > --- > drivers/staging/lustre/lustre/fld/lproc_fld.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c > index 8c5a657..3235194 100644 > --- a/drivers/staging/lustre/lustre/fld/lproc_fld.c > +++ b/drivers/staging/lustre/lustre/fld/lproc_fld.c > @@ -168,4 +168,4 @@ struct lprocfs_vars fld_client_proc_list[] = { > { "targets", &fld_proc_targets_fops }, > { "hash", &fld_proc_hash_fops }, > { "cache_flush", &fld_proc_cache_flush_fops }, > - { NULL }}; > + { NULL } }; The generally preferred form would be: struct lprocfs_vars fld_client_proc_list[] = { { "targets", &fld_proc_targets_fops }, { "hash", &fld_proc_hash_fops }, { "cache_flush", &fld_proc_cache_flush_fops }, { NULL } }; though that "{ NULL }" is just more commonly "{}," And it's probably better to remove this from the .h file and this file and move it to the one place it's actually used and make it static (const too eventually) $ git grep -w fld_client_proc_list drivers/staging/lustre/lustre/fld/fld_internal.h:extern struct lprocfs_vars fld_client_proc_list[]; drivers/staging/lustre/lustre/fld/fld_request.c: fld_client_proc_list, fld); drivers/staging/lustre/lustre/fld/lproc_fld.c:struct lprocfs_vars fld_client_proc_list[] = {