From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753136AbbCHWHJ (ORCPT ); Sun, 8 Mar 2015 18:07:09 -0400 Received: from smtprelay0075.hostedemail.com ([216.40.44.75]:60044 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752361AbbCHWHF (ORCPT ); Sun, 8 Mar 2015 18:07:05 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:421:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1568:1593:1594:1711:1714:1730:1747:1777:1792:2194:2199:2393:2559:2562:2691:2828:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3872:4321:5007:6261:7903:10004:10400:10848:11232:11658:11914:12517:12519:12663:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: girls40_3d9ce381f6133 X-Filterd-Recvd-Size: 1505 Message-ID: <1425852422.2745.2.camel@perches.com> Subject: Re: [PATCH 3/3] staging: lustre: space required after that close brace '}' From: Joe Perches To: Alberto Pires de Oliveira Neto Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, Greg KH , linux-kernel@vger.kernel.org Date: Sun, 08 Mar 2015 15:07:02 -0700 In-Reply-To: References: <90200ddcea30fa779b41e5833514a2a66a8862ef.1425845842.git.mrpenguin2005@gmail.com> <1425848020.5898.13.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-03-08 at 19:04 -0300, Alberto Pires de Oliveira Neto wrote: > It make sense. But I would also have move some dependencies as well. > As I'm still very new to the kernel, and on my first patches, I > believe it's safer to stick to the clean up. > So I'll leave the moving of the structure up to the maintainers if it's ok. Don't be afraid of making sensible changes.