[PATCH 0/3] staging: lustre: Fix checkpatch.pl warnings.

[PATCH 0/3] staging: lustre: Fix checkpatch.pl warnings.

[Alberto Pires de Oliveira Neto]

Alberto Pires de Oliveira Neto (3):
  staging: lustre: space prohibited between function name and open parenthesis '('
  staging: lustre: void function return statements are not generally useful.
  staging: lustre: space required after that close brace '}'

 drivers/staging/lustre/lustre/fld/fld_internal.h | 2 +-
 drivers/staging/lustre/lustre/fld/fld_request.c  | 1 -
 drivers/staging/lustre/lustre/fld/lproc_fld.c    | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

-- 
1.9.1

[PATCH 1/3] staging: lustre: space prohibited between function name and open parenthesis '('

[Alberto Pires de Oliveira Neto]

This patch fixes checkpatch.pl warning.
WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
---
 drivers/staging/lustre/lustre/fld/fld_internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/fld/fld_internal.h b/drivers/staging/lustre/lustre/fld/fld_internal.h
index 6125bbe..68bec765 100644
--- a/drivers/staging/lustre/lustre/fld/fld_internal.h
+++ b/drivers/staging/lustre/lustre/fld/fld_internal.h
@@ -142,7 +142,7 @@ extern struct lu_fld_hash fld_hash[];
 int fld_client_rpc(struct obd_export *exp,
 		   struct lu_seq_range *range, __u32 fld_op);
 
-#if defined (CONFIG_PROC_FS)
+#if defined(CONFIG_PROC_FS)
 extern struct lprocfs_vars fld_client_proc_list[];
 #endif
 
-- 
1.9.1

[PATCH 2/3] staging: lustre: void function return statements are not generally useful.

[Alberto Pires de Oliveira Neto]

This patch fixes checkpatch.pl warning.
WARNING: void function return statements are not generally useful

Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
---
 drivers/staging/lustre/lustre/fld/fld_request.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/lustre/lustre/fld/fld_request.c
index 22e0d94..6ac225e 100644
--- a/drivers/staging/lustre/lustre/fld/fld_request.c
+++ b/drivers/staging/lustre/lustre/fld/fld_request.c
@@ -326,7 +326,6 @@ static int fld_client_proc_init(struct lu_client_fld *fld)
 
 void fld_client_proc_fini(struct lu_client_fld *fld)
 {
-	return;
 }
 #endif
 EXPORT_SYMBOL(fld_client_proc_fini);
-- 
1.9.1

[PATCH 3/3] staging: lustre: space required after that close brace '}'

[Alberto Pires de Oliveira Neto]

This patch fixes checkpatch.pl warning.
WARNING: space required after that close brace '}'

Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
---
 drivers/staging/lustre/lustre/fld/lproc_fld.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c
index 8c5a657..3235194 100644
--- a/drivers/staging/lustre/lustre/fld/lproc_fld.c
+++ b/drivers/staging/lustre/lustre/fld/lproc_fld.c
@@ -168,4 +168,4 @@ struct lprocfs_vars fld_client_proc_list[] = {
 	{ "targets", &fld_proc_targets_fops },
 	{ "hash", &fld_proc_hash_fops },
 	{ "cache_flush", &fld_proc_cache_flush_fops },
-	{ NULL }};
+	{ NULL } };
-- 
1.9.1

Re: [PATCH 3/3] staging: lustre: space required after that close brace '}'

[Joe Perches]

On Sun, 2015-03-08 at 17:43 -0300, Alberto Pires de Oliveira Neto wrote:
> This patch fixes checkpatch.pl warning.
> WARNING: space required after that close brace '}'
> 
> Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
> ---
>  drivers/staging/lustre/lustre/fld/lproc_fld.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> index 8c5a657..3235194 100644
> --- a/drivers/staging/lustre/lustre/fld/lproc_fld.c
> +++ b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> @@ -168,4 +168,4 @@ struct lprocfs_vars fld_client_proc_list[] = {
>  	{ "targets", &fld_proc_targets_fops },
>  	{ "hash", &fld_proc_hash_fops },
>  	{ "cache_flush", &fld_proc_cache_flush_fops },
> -	{ NULL }};
> +	{ NULL } };

The generally preferred form would be:

struct lprocfs_vars fld_client_proc_list[] = {
	{ "targets", &fld_proc_targets_fops },
	{ "hash", &fld_proc_hash_fops },
	{ "cache_flush", &fld_proc_cache_flush_fops },
	{ NULL }
};

though that "{ NULL }" is just more commonly "{},"

And it's probably better to remove this from the .h
file and this file and move it to the one place it's
actually used and make it static (const too eventually)

$ git grep -w fld_client_proc_list
drivers/staging/lustre/lustre/fld/fld_internal.h:extern struct lprocfs_vars fld_client_proc_list[];
drivers/staging/lustre/lustre/fld/fld_request.c:                              fld_client_proc_list, fld);
drivers/staging/lustre/lustre/fld/lproc_fld.c:struct lprocfs_vars fld_client_proc_list[] = {

Re: [PATCH 3/3] staging: lustre: space required after that close brace '}'

[Alberto Pires de Oliveira Neto]

It make sense. But I would also have move some dependencies as well.
As I'm still very new to the kernel, and on my first patches, I
believe it's safer to stick to the clean up.
So I'll leave the moving of the structure up to the maintainers if it's ok.


On Sun, Mar 8, 2015 at 5:53 PM, Joe Perches <joe@perches.com> wrote:
> On Sun, 2015-03-08 at 17:43 -0300, Alberto Pires de Oliveira Neto wrote:
>> This patch fixes checkpatch.pl warning.
>> WARNING: space required after that close brace '}'
>>
>> Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
>> ---
>>  drivers/staging/lustre/lustre/fld/lproc_fld.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c
>> index 8c5a657..3235194 100644
>> --- a/drivers/staging/lustre/lustre/fld/lproc_fld.c
>> +++ b/drivers/staging/lustre/lustre/fld/lproc_fld.c
>> @@ -168,4 +168,4 @@ struct lprocfs_vars fld_client_proc_list[] = {
>>       { "targets", &fld_proc_targets_fops },
>>       { "hash", &fld_proc_hash_fops },
>>       { "cache_flush", &fld_proc_cache_flush_fops },
>> -     { NULL }};
>> +     { NULL } };
>
> The generally preferred form would be:
>
> struct lprocfs_vars fld_client_proc_list[] = {
>         { "targets", &fld_proc_targets_fops },
>         { "hash", &fld_proc_hash_fops },
>         { "cache_flush", &fld_proc_cache_flush_fops },
>         { NULL }
> };
>
> though that "{ NULL }" is just more commonly "{},"
>
> And it's probably better to remove this from the .h
> file and this file and move it to the one place it's
> actually used and make it static (const too eventually)
>
> $ git grep -w fld_client_proc_list
> drivers/staging/lustre/lustre/fld/fld_internal.h:extern struct lprocfs_vars fld_client_proc_list[];
> drivers/staging/lustre/lustre/fld/fld_request.c:                              fld_client_proc_list, fld);
> drivers/staging/lustre/lustre/fld/lproc_fld.c:struct lprocfs_vars fld_client_proc_list[] = {
>
>

Re: [PATCH 3/3] staging: lustre: space required after that close brace '}'

[Joe Perches]

On Sun, 2015-03-08 at 19:04 -0300, Alberto Pires de Oliveira Neto wrote:
> It make sense. But I would also have move some dependencies as well.
> As I'm still very new to the kernel, and on my first patches, I
> believe it's safer to stick to the clean up.
> So I'll leave the moving of the structure up to the maintainers if it's ok.

Don't be afraid of making sensible changes.

Re: [PATCH 3/3] staging: lustre: space required after that close brace '}'

[Alberto Pires de Oliveira Neto]

ok, I'll give it a try.

On Sun, Mar 8, 2015 at 7:07 PM, Joe Perches <joe@perches.com> wrote:
> On Sun, 2015-03-08 at 19:04 -0300, Alberto Pires de Oliveira Neto wrote:
>> It make sense. But I would also have move some dependencies as well.
>> As I'm still very new to the kernel, and on my first patches, I
>> believe it's safer to stick to the clean up.
>> So I'll leave the moving of the structure up to the maintainers if it's ok.
>
> Don't be afraid of making sensible changes.
>
>

Re: [PATCH 3/3] staging: lustre: space required after that close brace '}'

[Alberto Pires de Oliveira Neto]

it seems that I would have to move all file operations specific to
proc_fs from lproc_fld to fld_request.
Although the proc_fs seems to be used only from fld_request, it still
seems cleaner to keep them separated than put it all together.






On Sun, Mar 8, 2015 at 5:53 PM, Joe Perches <joe@perches.com> wrote:
> On Sun, 2015-03-08 at 17:43 -0300, Alberto Pires de Oliveira Neto wrote:
>> This patch fixes checkpatch.pl warning.
>> WARNING: space required after that close brace '}'
>>
>> Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
>> ---
>>  drivers/staging/lustre/lustre/fld/lproc_fld.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c
>> index 8c5a657..3235194 100644
>> --- a/drivers/staging/lustre/lustre/fld/lproc_fld.c
>> +++ b/drivers/staging/lustre/lustre/fld/lproc_fld.c
>> @@ -168,4 +168,4 @@ struct lprocfs_vars fld_client_proc_list[] = {
>>       { "targets", &fld_proc_targets_fops },
>>       { "hash", &fld_proc_hash_fops },
>>       { "cache_flush", &fld_proc_cache_flush_fops },
>> -     { NULL }};
>> +     { NULL } };
>
> The generally preferred form would be:
>
> struct lprocfs_vars fld_client_proc_list[] = {
>         { "targets", &fld_proc_targets_fops },
>         { "hash", &fld_proc_hash_fops },
>         { "cache_flush", &fld_proc_cache_flush_fops },
>         { NULL }
> };
>
> though that "{ NULL }" is just more commonly "{},"
>
> And it's probably better to remove this from the .h
> file and this file and move it to the one place it's
> actually used and make it static (const too eventually)
>
> $ git grep -w fld_client_proc_list
> drivers/staging/lustre/lustre/fld/fld_internal.h:extern struct lprocfs_vars fld_client_proc_list[];
> drivers/staging/lustre/lustre/fld/fld_request.c:                              fld_client_proc_list, fld);
> drivers/staging/lustre/lustre/fld/lproc_fld.c:struct lprocfs_vars fld_client_proc_list[] = {
>
>