Re: [PATCH 1/4] perf, tools: Output running time and run/enabled ratio in CSV mode

Andi Kleen
2015-03-10T15:37:11Z

> Why not handle both cases here?
>
> static void print_running(u64 run, u64 ena)
> {
> if (csv_output)
> fprintf(output, ...);
> else if (run != ena)
> fprintf(output, ...);
> }

print_running has 6 callers. run != ena is only needed
for two of them. So I don't think it makes sense to do.

-Andi