From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752529AbbCIHLo (ORCPT ); Mon, 9 Mar 2015 03:11:44 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:37524 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752044AbbCIHLn (ORCPT ); Mon, 9 Mar 2015 03:11:43 -0400 Message-ID: <1425885096.2440.6.camel@mm-sol.com> Subject: Re: [RFC PATCH] spi: Ensure that CS line is in non-active state after setup From: "Ivan T. Ivanov" To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Date: Mon, 09 Mar 2015 09:11:36 +0200 In-Reply-To: <20150308200142.GC28806@sirena.org.uk> References: <1425656716-25363-1-git-send-email-iivanov@mm-sol.com> <20150308200142.GC28806@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.7-fta1.2~trusty Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-03-08 at 20:01 +0000, Mark Brown wrote: > On Fri, Mar 06, 2015 at 05:45:15PM +0200, Ivan T. Ivanov wrote: > > > if (spi->master->setup) > > status = spi->master->setup(spi); > > + else > > + spi_set_cs(spi, false); > > Why would this be conditional on there not being a setup operation? > It's a good idea, I just don't see why the backstop isn't always useful. I was thinking that this is expected to be handled inside setup operation, nothing more. Ivan