From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753334AbbCIMN1 (ORCPT ); Mon, 9 Mar 2015 08:13:27 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:64988 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753701AbbCIMNY (ORCPT ); Mon, 9 Mar 2015 08:13:24 -0400 X-AuditID: cbfec7f5-b7fc86d0000066b7-cd-54fd8dcb078f Message-id: <1425903199.13415.9.camel@AMDC1943> Subject: Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver From: Krzysztof Kozlowski To: Beomho Seo Cc: Lee Jones , Sebastian Reichel , Jaewon Kim , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chanwoo Choi , Dmitry Torokhov Date: Mon, 09 Mar 2015 13:13:19 +0100 In-reply-to: <54FD880E.30903@samsung.com> References: <1425291038-18269-1-git-send-email-jaewon02.kim@samsung.com> <1425291038-18269-3-git-send-email-jaewon02.kim@samsung.com> <20150307201340.GF5233@earth> <54FCEABE.9000007@samsung.com> <54FD880E.30903@samsung.com> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-version: 1.0 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsVy+t/xy7qne/+GGJw5I29x+tM2dovrX56z Wsw/co7V4vCiF4wW/W8Wslqce7WS0WLS/QksFjsajrBa3P96lNHi5qdvrBaXd81hs/jce4TR Yun1i0wWE6avZbFo3XuE3eL4p4MsFqd3lzgIeqyZt4bR43JfL5PHzll32T1WLv/C5rFpVSeb x51re9g8+rasYvT4vEkugCOKyyYlNSezLLVI3y6BK+Ni63umgqviFd13Z7M1MP4T6mLk5JAQ MJE4e+UGE4QtJnHh3nq2LkYuDiGBpYwSr8+8YYVwPjNKzH9xjBmkildAX2JqyxJGEFtYIFJi 4rbrbCA2m4CxxOblS8BsEQF1iZ13OplBmpkFjrFILFu4hAUkwSKgKvHu7Cwwm1NAU+LJ7C6o dWuYJF79Xgu2gRmoe9K8RUA2B9BNyhKN/W4QiwUlfky+xwJRIi+xec1b5gmMArOQdMxCUjYL SdkCRuZVjKKppckFxUnpuUZ6xYm5xaV56XrJ+bmbGCGR9nUH49JjVocYBTgYlXh4Gyr+hgix JpYVV+YeYpTgYFYS4Y3pBArxpiRWVqUW5ccXleakFh9iZOLglGpgXCbJWTipI2b3KTWdfW37 n9zL8A+enLP6rcgtpsNa1hmczrf6JTc7sd2O97j9S3fNGYu1ZUsjRbVWpNUY5ngve/RMeu4M q5mnP3O8ZlPZ/Z3jsqLSjmvG4V/DzlZ+5t3PLrqzfl3JYxaOi3O6GG7ZH8l++OAD17R9hWUO 03bfmpUbHSqj6DfLX4mlOCPRUIu5qDgRAO52hJSSAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pon, 2015-03-09 at 20:46 +0900, Beomho Seo wrote: > On 03/09/2015 08:02 PM, Krzysztof Kozlowski wrote: > > 2015-03-09 1:35 GMT+01:00 Beomho Seo : > >> On 03/08/2015 05:13 AM, Sebastian Reichel wrote: > >>> On Mon, Mar 02, 2015 at 07:10:35PM +0900, Jaewon Kim wrote: > >>>> From: Beomho Seo > >>>> > >>>> This patch adds device driver of max77843 charger. This driver provide > >>>> initialize each charging mode(e.g. fast charge, top-off mode and constant > >>>> charging mode so on.). Additionally, control charging paramters to use > >>>> i2c interface. > >>>> > >>>> Cc: Sebastian Reichel > >>>> Signed-off-by: Beomho Seo > >>> > >>> Reviewed-By: Sebastian Reichel > >>> > >>> I can't take it as is, since it depends on the private header file > >>> of PATCHv1. > >>> > >>> -- Sebastian > >>> > >> > >> This patch reviewed by Sebastian. > >> Could you Please merge that your git tree ? > > > > Hi, > > > > ... and again we are adding a new driver for very similar chipset to > > already supported. I looked at spec and the charger's registers are > > almost the same as for max77693. Their layout and addresses are the > > same. I see some minor differences, probably the most important would > > be different values current (fast-charge, top-off). But still 90% of > > registers are the same... Do we really have to add new driver? > > > > Best regards, > > Krzysztof > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-input" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > Hi, > > Thank you for your comment. As you say, both chip set are similar. > But new driver need for support max77843. It is support different below > - Provide Battery presence information. Another set of power supply properties could be added for that chip. This way the get_property() function would be the same but actually the POWER_SUPPLY_PROP_PRESENT won't be called for max77693. > - Can OTG FET control. Where the OTG FET feature is it enabled in your driver? I couldn't find it. > - Bigger Fast charge current, Top Off current Threshold selection. > - Various and bigger OTG current limitation. > - Bigger primary charger termination voltage setting. > - Different maximum input current limit selection(Different step). Yes, I mentioned some of these differences (the Fast/top-off differences). These are differences in values so it does not require new driver. There is need to develop new driver just to support different current (3.0 A instead of 2.1 A) or voltage threshold. So the only new feature - battery presence - can be easily added to existing driver. The driver can be extended for different current/voltage values. Such extension may even be beneficial for new Maxim MUIC/PMIC chipsets. Best regards, Krzysztof