From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933005AbbCIOVW (ORCPT ); Mon, 9 Mar 2015 10:21:22 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:46942 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932295AbbCIOVR (ORCPT ); Mon, 9 Mar 2015 10:21:17 -0400 Message-ID: <1425910873.11323.20.camel@gmail.com> Subject: Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock From: Matteo Semenzato Reply-To: 20150309091618.GA10964@mwanda To: Dan Carpenter Cc: "linux-kernel@vger.kernel.org" Date: Mon, 09 Mar 2015 15:21:13 +0100 In-Reply-To: <20150309091618.GA10964@mwanda> References: <1425742407-6619-1-git-send-email-mattew8898@gmail.com> <20150309091618.GA10964@mwanda> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il giorno lun, 09/03/2015 alle 12.16 +0300, Dan Carpenter ha scritto: > Why is it a RESEND? > > RESEND is a bit rude because it implies that we messed up by ignoring > your first email so you're sending us the exact same thing again. > Sometimes rudeness is valid if people are ignoring good patches but you > send the first email 4 minutes before sending the second email. This patch is a RESEND because i forgot to remove PATCH 2/2 from the subject. > On Sat, Mar 07, 2015 at 04:33:27PM +0100, Matteo Semenzato wrote: > > From: Matteo Semenzato > > No need for this, we can get it from your email. > > > > > The rtw_cmd_thread semaphore was being unlocked twice. > > This patch is probably correct, but it's a bit risky without testing or > further analysis. Please explain how you verified that it won't cause > a deadlock. This patch is wrong because it tries to call down on a semaphore that is initialized to 0 and the semaphore is not unlocked anywhere else.