From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873AbbCIS1u (ORCPT ); Mon, 9 Mar 2015 14:27:50 -0400 Received: from smtprelay0250.hostedemail.com ([216.40.44.250]:42639 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751438AbbCIS1r (ORCPT ); Mon, 9 Mar 2015 14:27:47 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2914:3138:3139:3140:3141:3142:3353:3622:3865:3867:3870:3872:3873:3874:4321:4398:5007:6261:7514:10004:10400:10848:11026:11232:11658:11914:12043:12296:12438:12517:12519:12740:13019:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: snail36_60d813339c740 X-Filterd-Recvd-Size: 3002 Message-ID: <1425925663.5428.43.camel@perches.com> Subject: Re: [PATCH v2] driver core: fix several coding style warnings From: Joe Perches To: Ioana Antoche Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Date: Mon, 09 Mar 2015 11:27:43 -0700 In-Reply-To: <1425924536-8583-1-git-send-email-ioana.antoche@gmail.com> References: <1425924536-8583-1-git-send-email-ioana.antoche@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-09 at 20:08 +0200, Ioana Antoche wrote: > Fix checkpatch.pl warnings such as: > * missing blank line after declarations > * line over 80 characters > > Signed-off-by: Ioana Antoche > --- > * undo changes related to "ERROR: that open brace { should be on the previous line". Not quite. > diff --git a/drivers/base/bus.c b/drivers/base/bus.c > @@ -298,8 +299,7 @@ static struct device *next_device(struct klist_iter *i) > * count in the supplied callback. > */ > int bus_for_each_dev(struct bus_type *bus, struct device *start, > - void *data, int (*fn)(struct device *, void *)) > -{ > + void *data, int (*fn)(struct device *, void *)) { Don't want this change here. > @@ -395,7 +395,8 @@ struct device *subsys_find_device_by_id(struct bus_type *subsys, unsigned int id > return NULL; > > if (hint) { > - klist_iter_init_node(&subsys->p->klist_devices, &i, &hint->p->knode_bus); > + klist_iter_init_node(&subsys->p->klist_devices, &i, > + &hint->p->knode_bus); Please run your patches though checkpatch --strict. This second line should be aligned to the open parenthesis like: klist_iter_init_node(&subsys->p->klist_devices, &i, &hint->p->knode_bus); > @@ -448,8 +449,7 @@ static struct device_driver *next_driver(struct klist_iter *i) > * so it doesn't disappear before returning to the caller. > */ > int bus_for_each_drv(struct bus_type *bus, struct device_driver *start, > - void *data, int (*fn)(struct device_driver *, void *)) > -{ > + void *data, int (*fn)(struct device_driver *, void *)) { Maybe you re-sent your original patch? > @@ -1092,7 +1095,8 @@ struct device *subsys_dev_iter_next(struct subsys_dev_iter *iter) > knode = klist_next(&iter->ki); > if (!knode) > return NULL; > - dev = container_of(knode, struct device_private, knode_bus)->device; > + dev = container_of(knode, struct device_private, knode_bus) > + ->device; That's not nice to read. If it exceeds 80 columns, just leave it alone or if it really bothers you, use a temporary for container_of then dereference that.