From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753998AbbCJQZ0 (ORCPT ); Tue, 10 Mar 2015 12:25:26 -0400 Received: from smtprelay0207.hostedemail.com ([216.40.44.207]:59382 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753029AbbCJQZV (ORCPT ); Tue, 10 Mar 2015 12:25:21 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:1981:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3872:3874:4250:4321:5007:6261:7903:10004:10400:10848:11658:11914:12517:12519:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: sack92_68a58ecabc950 X-Filterd-Recvd-Size: 1562 Message-ID: <1426004716.18060.10.camel@perches.com> Subject: Re: [PATCH 00/56] staging: comedi: introduce comedi_pci.h header From: Joe Perches To: Ian Abbott Cc: driverdev-devel@linuxdriverproject.org, Greg Kroah-Hartman , H Hartley Sweeten , linux-kernel@vger.kernel.org Date: Tue, 10 Mar 2015 09:25:16 -0700 In-Reply-To: <1426003875-27653-1-git-send-email-abbotti@mev.co.uk> References: <1426003875-27653-1-git-send-email-abbotti@mev.co.uk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-10 at 16:10 +0000, Ian Abbott wrote: > "comedidev.h" includes PCI-specific stuff that gets included by all > comedi drivers including non-PCI ones. Separate it out into its own > header "comedi_pci.h". Make the new header include and > "comedidev.h" so that comedi PCI drivers do not need to include them > explicitly. Isn't the kernel progressing to avoid indirect includes? Perhaps it'd be nicer to move generic comedi .h files into a more common location and change the include path so that the include statements don't have to be relative? Maybe add an include/comedi/ directory?