From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753316AbbCJU3G (ORCPT ); Tue, 10 Mar 2015 16:29:06 -0400 Received: from smtprelay0048.hostedemail.com ([216.40.44.48]:49299 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752979AbbCJU3D (ORCPT ); Tue, 10 Mar 2015 16:29:03 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:421:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2903:3138:3139:3140:3141:3142:3355:3622:3653:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:6261:7903:8603:8957:10004:10400:10848:11026:11232:11473:11658:11914:12296:12438:12517:12519:12663:12740:13161:13229:14093:14096:14097:21063:21080:21088,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: cook19_31804d61d774d X-Filterd-Recvd-Size: 3508 Message-ID: <1426019338.18060.34.camel@perches.com> Subject: Re: [PATCH] mtd: clean up whitespace in linux/mtd/map.h From: Joe Perches To: Brian Norris Cc: Arnd Bergmann , David Woodhouse , Jingoo Han , linux-mtd@lists.infradead.org, Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 10 Mar 2015 13:28:58 -0700 In-Reply-To: <20150310195832.GD4124@norris-Latitude-E6410> References: <2266200.3mx7btcFe5@wuerfel> <2220416.D2kDyFWh1C@wuerfel> <1426012416.18060.22.camel@perches.com> <20150310195832.GD4124@norris-Latitude-E6410> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-10 at 12:58 -0700, Brian Norris wrote: > On Tue, Mar 10, 2015 at 11:33:36AM -0700, Joe Perches wrote: > > On Tue, 2015-03-10 at 17:51 +0100, Arnd Bergmann wrote: > > > As the only comments I got for the "mtd: cfi: reduce stack size" > > > patch were about whitespace changes, it appears necessary to fix > > > up the rest of the file as well, which contains the exact same > > > mistakes. > > > > trivia: > > > > > diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h > > [] > > > @@ -77,7 +77,7 @@ > > > /* ensure we never evaluate anything shorted than an unsigned long > > > * to zero, and ensure we'll never miss the end of an comparison (bjd) */ > > > > > > -#define map_calc_words(map) ((map_bankwidth(map) + (sizeof(unsigned long)-1))/ sizeof(unsigned long)) > > > +#define map_calc_words(map) ((map_bankwidth(map) + (sizeof(unsigned long)-1)) / sizeof(unsigned long)) > > > > DIV_ROUND_UP? > > > > > #ifdef CONFIG_MTD_MAP_BANK_WIDTH_8 > > > # ifdef map_bankwidth > > > @@ -181,7 +181,7 @@ static inline int map_bankwidth_supported(int w) > > > } > > > } > > > > > > -#define MAX_MAP_LONGS ( ((MAX_MAP_BANKWIDTH*8) + BITS_PER_LONG - 1) / BITS_PER_LONG ) > > > +#define MAX_MAP_LONGS (((MAX_MAP_BANKWIDTH * 8) + BITS_PER_LONG - 1) / BITS_PER_LONG) > > > > BITS_TO_LONGS? > > It seems the $subject patch is really not that necessary, Coding style patches rarely are. > as it was just > inspired by similarly trivial comments. But I thought CodingStyle > was supposed to mostly be a guide for new code, not a charter to "fix > up" old code like drivers/mtd/{chips,maps}. 'tisn't but consistency has its own virtue. > So I would have been happy with ignoring the whitespace comments on the > v1 stack usage patch (esp. since it *did* match the existing style), and > avoiding the ensuing comments about helper macros. IMO, it's pretty > silly when a simple patch to fix a real issue turns into an extended > search for other trivial issues. > > I'll probably take both of Arnd's patches as they stand, No worries. The comments weren't meant to derail the original patches. > but any more > trivial requests to stable code like this should come in the form of > real patches, not respins of Arnd's patch. I'm not respinning the patches. If Arnd wants to do more work, that's up to him.