From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752508AbbCKAGb (ORCPT ); Tue, 10 Mar 2015 20:06:31 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:43589 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbbCKAG2 (ORCPT ); Tue, 10 Mar 2015 20:06:28 -0400 Message-ID: <1426032383.5707.1.camel@phoenix> Subject: [PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path From: Axel Lin To: Kishon Vijay Abraham I Cc: Julia Lawall , Sylwester Nawrocki , Kyungmin Park , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Wed, 11 Mar 2015 08:06:23 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the second lock on non-regmap path. Fixes: 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations) Reported-by: Julia Lawall Signed-off-by: Axel Lin --- drivers/phy/phy-exynos-mipi-video.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c index 8d6d117..df7519a 100644 --- a/drivers/phy/phy-exynos-mipi-video.c +++ b/drivers/phy/phy-exynos-mipi-video.c @@ -75,7 +75,6 @@ static int __set_phy_state(struct exynos_mipi_video_phy *state, } else { addr = state->regs + EXYNOS_MIPI_PHY_CONTROL(id / 2); - spin_lock(&state->slock); val = readl(addr); if (on) val |= reset; -- 1.9.1