From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752306AbbCKK3e (ORCPT ); Wed, 11 Mar 2015 06:29:34 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:32577 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbbCKK3a (ORCPT ); Wed, 11 Mar 2015 06:29:30 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f4-b7f126d000001e9a-f2-550018769522 Content-transfer-encoding: 8BIT Message-id: <1426069765.30407.7.camel@AMDC1943> Subject: Re: [PATCH v2] ARM: EXYNOS: Fix failed second suspend on Exynos4 From: Krzysztof Kozlowski To: Kukjin Kim , Arnd Bergmann , Olof Johansson Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski , stable@vger.kernel.org, BartlomiejZolnierkiewicz Date: Wed, 11 Mar 2015 11:29:25 +0100 In-reply-to: <1426069206-13667-1-git-send-email-k.kozlowski@samsung.com> References: <1426069206-13667-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: Evolution 3.10.4-0ubuntu2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBLMWRmVeSWpSXmKPExsVy+t/xK7plEgyhBqc/SVn8nXSM3WLjjPWs Fv2PXzNbbHp8jdXi8q45bBYzzu9jslh75C67xanrn9ksFmx8xOjA6fH71yRGj02rOtk8Ni+p 97hyoonVo2/LKkaPz5vkAtiiuGxSUnMyy1KL9O0SuDLut25mLLjPXzFz4hTGBsZLPF2MnBwS AiYSZ5feYYewxSQu3FvP1sXIxSEksJRR4ufeY0wgCV4BQYkfk++xdDFycDALyEscuZQNEmYW UJeYNG8RM0T9Z0aJ17NbmCHq9SXWPW9hBLGFBTwl5u17xAZiswkYS2xevoQNZI6IQLLE3KPs IL3MAs8ZJXbv+AlWwyKgKnHg6zEwm1PAQ2L/y3/MIPVCAu4SD9fogJgSAsoSjf1uExgFZiE5 bhbCcbOQHLeAkXkVo2hqaXJBcVJ6rqFecWJucWleul5yfu4mRkjof9nBuPiY1SFGAQ5GJR7e m9H/QoRYE8uKK3MPMUpwMCuJ8PbxM4QK8aYkVlalFuXHF5XmpBYfYmTi4JRqYNSOtAvZ80tP 9bZI1EY3frZrnkoRwRVTZz9f6GQ49cLDWp4XsS9miirvEk29VGkkb3fisePyLWmtrQvlyvd7 vJ9xMFC+z2plwuzK4hhOf6bipznhB3e8c1kl3LbSdIsei3qrzvs+zycyGbf2+xxb3BD5/z9D 8aMLx/3PPL83V/1U7iPrMHlNUSWW4oxEQy3mouJEAIOua5dbAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On śro, 2015-03-11 at 11:20 +0100, Krzysztof Kozlowski wrote: > On Exynos4412 boards (Trats2, Odroid U3) after enabling L2 cache in > 56b60b8bce4a ("ARM: 8265/1: dts: exynos4: Add nodes for L2 cache > controller") the second suspend to RAM failed. First suspend worked fine > but the next one hang just after powering down of secondary CPUs (system > consumed energy as it would be running but was not responsive). > > The issue was caused by enabling delayed reset assertion for CPU0 just > after issuing power down of cores. This was introduced for Exynos4 in > 13cfa6c4f7fa ("ARM: EXYNOS: Fix CPU idle clock down after CPU off"). > > The whole behavior is not well documented but after checking with vendor > code this should be done like this (on Exynos4): > 1. Enable delayed reset assertion when system is running (for all CPUs). > 2. Disable delayed reset assertion before suspending the system. > This can be done after powering off secondary CPUs. > 3. Re-enable the delayed reset assertion when system is resumed. > > Signed-off-by: Krzysztof Kozlowski > Fixes: 13cfa6c4f7fa ("ARM: EXYNOS: Fix CPU idle clock down after CPU off") > Cc: > Tested-by: Bartlomiej Zolnierkiewicz > Tested-by: Chanwoo Choi Dear Kukjin, This patch was first sent on 3rd of February. It could enter before opening 4.0 merge window. I did not receive any response from you in that time. So let me point next steps: 1. The Exynos4412 suspend on 4.0 is broken and now this patch applies as a fix. 2. I resent it on 18th of February. 3. I received tested-by from Bartlomiej and Chanwoo. 4. Bartlomiej pinged you on 3rd March. Still no response. If the patch does not look good then please share your comments. I'll fix it. If this patch looks good, why does it take so much time? Dear Arnd and Olof, Could you pick it up to your arm-soc? Best regards, Krzysztof