public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
	vkuznets@redhat.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on add_memory() failure
Date: Wed, 11 Mar 2015 18:56:55 -0700	[thread overview]
Message-ID: <1426125419-12571-2-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1426125419-12571-1-git-send-email-kys@microsoft.com>

From: Vitaly Kuznetsov <vkuznets@redhat.com>

When add_memory() fails the following BUG is observed:
[  743.646107] hv_balloon: hot_add memory failed error is -17
[  743.679973]
[  743.680930] =====================================
[  743.680930] [ BUG: bad unlock balance detected! ]
[  743.680930] 3.19.0-rc5_bug1131426+ #552 Not tainted
[  743.680930] -------------------------------------
[  743.680930] kworker/0:2/255 is trying to release lock (&dm_device.ha_region_mutex) at:
[  743.680930] [<ffffffff81aae5fe>] mutex_unlock+0xe/0x10
[  743.680930] but there are no more locks to release!

This happens as we don't acquire ha_region_mutex and hot_add_req() expects us
to as it does unconditional mutex_unlock(). Acquire the lock on the error path.

The current Linux 4.0 RC3 tree is broken and this patch fixes the problem.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hv/hv_balloon.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
index c5bb872..f1f17c5 100644
--- a/drivers/hv/hv_balloon.c
+++ b/drivers/hv/hv_balloon.c
@@ -652,6 +652,7 @@ static void hv_mem_hot_add(unsigned long start, unsigned long size,
 			}
 			has->ha_end_pfn -= HA_CHUNK;
 			has->covered_end_pfn -=  processed_pfn;
+			mutex_lock(&dm_device.ha_region_mutex);
 			break;
 		}
 
-- 
1.7.4.1


  reply	other threads:[~2015-03-12  0:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12  1:55 [PATCH 0/6] drivers: hv: vmbus: Some miscellaneous fixes for Linux 4.0 K. Y. Srinivasan
2015-03-12  1:56 ` [PATCH 1/6] Drivers: hv: vmbus: Perform device register in the per-channel work element K. Y. Srinivasan
2015-03-12  1:56   ` K. Y. Srinivasan [this message]
2015-03-12 10:45     ` [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on add_memory() failure Olaf Hering
2015-03-12 10:53       ` Vitaly Kuznetsov
2015-03-12 11:14         ` Olaf Hering
2015-03-12 11:41           ` Dan Carpenter
2015-03-12 12:44           ` KY Srinivasan
2015-03-12  1:56   ` [PATCH 3/6] Drivers: hv: hv_balloon: don't lose memory when onlining order is not natural K. Y. Srinivasan
2015-03-12  1:56   ` [PATCH 4/6] Correcting truncation error for constant HV_CRASH_CTL_CRASH_NOTIFY K. Y. Srinivasan
2015-03-12  1:56   ` [PATCH 5/6] tools: hv: fcopy_daemon: support >2GB files for x86_32 guest K. Y. Srinivasan
2015-03-12  1:56   ` [PATCH 6/6] Drivers: hv: vmbus: Fix a bug in rescind processing in vmbus_close_internal() K. Y. Srinivasan
2015-03-12  9:02   ` [PATCH 1/6] Drivers: hv: vmbus: Perform device register in the per-channel work element Greg KH
2015-03-12  9:03     ` Greg KH
2015-03-12 13:12       ` KY Srinivasan
2015-03-12 13:28         ` Greg KH
2015-03-12 14:16           ` KY Srinivasan
2015-03-16 20:22             ` Greg KH
2015-03-16 21:09               ` KY Srinivasan
2015-03-17  4:50               ` KY Srinivasan
2015-03-12 10:44   ` Olaf Hering
2015-03-12 14:28     ` KY Srinivasan
2015-03-12 16:09       ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426125419-12571-2-git-send-email-kys@microsoft.com \
    --to=kys@microsoft.com \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox