From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com
Cc: Nick Meier <nmeier@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH 4/6] Correcting truncation error for constant HV_CRASH_CTL_CRASH_NOTIFY
Date: Wed, 11 Mar 2015 18:56:57 -0700 [thread overview]
Message-ID: <1426125419-12571-4-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1426125419-12571-1-git-send-email-kys@microsoft.com>
From: Nick Meier <nmeier@microsoft.com>
HV_CRASH_CTL_CRASH_NOTIFY is a 64 bit number. Depending on the usage context,
the value may be truncated. This patch is in response from the following
email from Intel:
[char-misc:char-misc-testing 25/45] drivers/hv/vmbus_drv.c:67:9: sparse:
constant 0x8000000000000000 is so big it is unsigned long
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
head: b3de8e3719e582f3182bb504295e4a8e43c8c96f
commit: 96c1d0581d00f7abe033350edb021a9d947d8d81 [25/45] Drivers: hv: vmbus: Add support for VMBus panic notifier handler
reproduce:
# apt-get install sparse
git checkout 96c1d0581d00f7abe033350edb021a9d947d8d81
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
drivers/hv/vmbus_drv.c:67:9: sparse: constant 0x8000000000000000 is so big it is unsigned long
...
The current Linux 4.0 RC3 tree is broken and this patch fixes the problem.
Signed-off-by: Nick Meier <nmeier@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/hv/hyperv_vmbus.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
index 6339589..c8e27e0 100644
--- a/drivers/hv/hyperv_vmbus.h
+++ b/drivers/hv/hyperv_vmbus.h
@@ -58,7 +58,7 @@ enum hv_cpuid_function {
#define HV_X64_MSR_CRASH_P4 0x40000104
#define HV_X64_MSR_CRASH_CTL 0x40000105
-#define HV_CRASH_CTL_CRASH_NOTIFY 0x8000000000000000
+#define HV_CRASH_CTL_CRASH_NOTIFY (1ULL << 63)
/* Define version of the synthetic interrupt controller. */
#define HV_SYNIC_VERSION (1)
--
1.7.4.1
next prev parent reply other threads:[~2015-03-12 0:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 1:55 [PATCH 0/6] drivers: hv: vmbus: Some miscellaneous fixes for Linux 4.0 K. Y. Srinivasan
2015-03-12 1:56 ` [PATCH 1/6] Drivers: hv: vmbus: Perform device register in the per-channel work element K. Y. Srinivasan
2015-03-12 1:56 ` [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on add_memory() failure K. Y. Srinivasan
2015-03-12 10:45 ` Olaf Hering
2015-03-12 10:53 ` Vitaly Kuznetsov
2015-03-12 11:14 ` Olaf Hering
2015-03-12 11:41 ` Dan Carpenter
2015-03-12 12:44 ` KY Srinivasan
2015-03-12 1:56 ` [PATCH 3/6] Drivers: hv: hv_balloon: don't lose memory when onlining order is not natural K. Y. Srinivasan
2015-03-12 1:56 ` K. Y. Srinivasan [this message]
2015-03-12 1:56 ` [PATCH 5/6] tools: hv: fcopy_daemon: support >2GB files for x86_32 guest K. Y. Srinivasan
2015-03-12 1:56 ` [PATCH 6/6] Drivers: hv: vmbus: Fix a bug in rescind processing in vmbus_close_internal() K. Y. Srinivasan
2015-03-12 9:02 ` [PATCH 1/6] Drivers: hv: vmbus: Perform device register in the per-channel work element Greg KH
2015-03-12 9:03 ` Greg KH
2015-03-12 13:12 ` KY Srinivasan
2015-03-12 13:28 ` Greg KH
2015-03-12 14:16 ` KY Srinivasan
2015-03-16 20:22 ` Greg KH
2015-03-16 21:09 ` KY Srinivasan
2015-03-17 4:50 ` KY Srinivasan
2015-03-12 10:44 ` Olaf Hering
2015-03-12 14:28 ` KY Srinivasan
2015-03-12 16:09 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426125419-12571-4-git-send-email-kys@microsoft.com \
--to=kys@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nmeier@microsoft.com \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox