From: "Raphaël Teysseyre" <rteysseyre@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Joe Xue <lgxue@hotmail.com>, Bryan Wu <cooloney@gmail.com>,
"rpurdie@rpsys.net" <rpurdie@rpsys.net>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] leds: Add status code trigger
Date: Thu, 12 Mar 2015 07:56:00 +0100 [thread overview]
Message-ID: <1426143360.59115.21.camel@localhost> (raw)
In-Reply-To: <20150311190255.GA20247@amd>
> > For a heartbeat-like pattern :
> > 0 1000
> > 255 100
> > 0 100
> > 255 100
>
> That would be "slowly go to zero intensity, quickly go to max
> intensity, to zero, to maximum". If you wanted to turn the LED on/off
> without going through partial brightnesses, you'd do
>
> 0 1000
> 255 0
> 255 100
> 0 0
> 0 100
> 255 0
> 255 100
> 0 0
>
Okay, now I get why there were zero-time lines in your second example.
> > pattern_repeat : repeat this pattern indefinitely ?
> > 1 -> yes, 0 -> no
> >
> > pattern_once : if pattern_repeat = 0, writing 1 to this
> > file makes the pattern run once .
>
> I'd do attribute "repeat" with number of repetitions, or -1 == "repeat
> forever" default value.
>
Yes that's better.
Best regards,
Raphaël
next prev parent reply other threads:[~2015-03-12 6:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1424334377.11286.3.camel@localhost>
2015-03-09 21:15 ` [PATCH RFC] leds: Add status code trigger Bryan Wu
2015-03-10 8:00 ` Pavel Machek
[not found] ` <BLU172-W3716E59BC9E98F60F424C4AC180@phx.gbl>
2015-03-10 19:22 ` Pavel Machek
2015-03-11 15:10 ` Raphaël Teysseyre
2015-03-11 19:02 ` Pavel Machek
2015-03-12 6:56 ` Raphaël Teysseyre [this message]
2015-03-16 10:06 ` [PATCH] leds: Add arbitrary pattern trigger Raphaël Teysseyre
2015-03-16 11:55 ` Pavel Machek
2015-03-16 16:49 ` Raphaël Teysseyre
2015-03-16 12:20 ` Pavel Machek
2015-03-16 12:40 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426143360.59115.21.camel@localhost \
--to=rteysseyre@gmail.com \
--cc=cooloney@gmail.com \
--cc=lgxue@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).