From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753377AbbCLIE1 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 Mar 2015 04:04:27 -0400
Received: from cpsmtpb-ews03.kpnxchange.com ([213.75.39.6]:54955 "EHLO
	cpsmtpb-ews03.kpnxchange.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752034AbbCLIER (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 Mar 2015 04:04:17 -0400
Message-ID: <1426147454.5304.9.camel@x220>
Subject: Re: [PATCH v7 11/18] memory: tegra: Add EMC (external memory
 controller) driver
From: Paul Bolle <pebolle@tiscali.nl>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-tegra@vger.kernel.org, Mikko Perttunen <mikko.perttunen@kapsi.fi>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Alexandre Courbot <gnurou@gmail.com>, Joerg Roedel <jroedel@suse.de>,
        linux-kernel@vger.kernel.org
Date: Thu, 12 Mar 2015 09:04:14 +0100
In-Reply-To: <1426070126-26910-12-git-send-email-tomeu.vizoso@collabora.com>
References: <1426070126-26910-1-git-send-email-tomeu.vizoso@collabora.com>
	 <1426070126-26910-12-git-send-email-tomeu.vizoso@collabora.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 12 Mar 2015 08:04:15.0136 (UTC) FILETIME=[21D9EA00:01D05C9B]
X-RcptDomain: vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-03-11 at 11:34 +0100, Tomeu Vizoso wrote:
> --- a/drivers/memory/tegra/Kconfig
> +++ b/drivers/memory/tegra/Kconfig
> +
> +

(Nit: just one empty line, please.)

> +config TEGRA124_EMC
> +	bool "Tegra124 External Memory Controller driver"

This patch adds a bool symbol...

> +	default y
> +	depends on TEGRA_MC && ARCH_TEGRA_124_SOC
> +	help
> +	  This driver is for the External Memory Controller (EMC) found on
> +	  Tegra124 chips. The EMC controls the external DRAM on the board.
> +	  This driver is required to change memory timings / clock rate for
> +	  external memory.
> \ No newline at end of file

(Another nit, reported by git.)

> --- a/drivers/memory/tegra/Makefile
> +++ b/drivers/memory/tegra/Makefile
> @@ -5,3 +5,5 @@ tegra-mc-$(CONFIG_ARCH_TEGRA_114_SOC) += tegra114.o
>  tegra-mc-$(CONFIG_ARCH_TEGRA_124_SOC) += tegra124.o
>  
>  obj-$(CONFIG_TEGRA_MC) += tegra-mc.o
> +
> +obj-$(CONFIG_TEGRA124_EMC) += tegra124-emc.o

... and tegra124-emc.o will never be part of a module ...

> --- /dev/null
> +++ b/drivers/memory/tegra/tegra124-emc.c

... so:

> +#include <linux/module.h>

- I guess linux/module.h is not needed;

> +MODULE_DEVICE_TABLE(of, tegra_emc_of_match);

- this macro will be preprocessed away;

> +static int tegra_emc_probe(struct platform_device *pdev)
> +{
> +	[...]
> +
> +	platform_set_drvdata(pdev, tegra);
> +
> +

(Nit: this adds two empty lines.)

> +	return 0;
> +};

> +MODULE_AUTHOR("Mikko Perttunen <mperttunen@nvidia.com>");
> +MODULE_DESCRIPTION("Tegra124 EMC memory driver");
> +MODULE_LICENSE("GPL v2");

- and these three macros will be, effectively, preprocessed away,