public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Jan Beulich <JBeulich@suse.com>
Cc: akpm@linux-foundation.org, Michal Marek <mmarek@suse.cz>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Kconfig: drop bogus default values
Date: Thu, 12 Mar 2015 13:41:53 +0100	[thread overview]
Message-ID: <1426164113.5304.54.camel@x220> (raw)
In-Reply-To: <5501966D0200007800068FFB@mail.emea.novell.com>

On Thu, 2015-03-12 at 12:36 +0000, Jan Beulich wrote:
> >>> On 12.03.15 at 13:11, <pebolle@tiscali.nl> wrote:
> > On Wed, 2015-03-11 at 13:59 +0000, Jan Beulich wrote:
> >> Default "no" is pretty pointless for options without (visible) prompts:
> > 
> > Related: is there ever a situation where using "default n" or "def_bool
> > n" makes sense (whether or not the entry has a prompt)? I think I once
> > thought of one but I can't remember it at all, so I guess my memory is
> > fooling me.
> 
> I can't see any, but since as long as there is a visible prompt this
> doesn't have any other bad effect than bloating the Kconfig file
> and making its parsing a tiny bit slower, I don't care that much
> about those (originally I had started a patch removing those too,
> but gave up after a while).

Well, unless someone comes up with a valid reason to add "default
n" (and, again, I don't think what you ran into is a valid reason) we
might instead bloat checkpatch.pl a bit by adding a warning for it. That
should at least stop new instances from being added.

I wonder whether Michal knows of a valid reason to use "default n"? What
are Jan and I missing here?


Paul Bolle


  reply	other threads:[~2015-03-12 12:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 13:59 [PATCH] Kconfig: drop bogus default values Jan Beulich
2015-03-12 12:11 ` Paul Bolle
2015-03-12 12:36   ` Jan Beulich
2015-03-12 12:41     ` Paul Bolle [this message]
2015-03-12 18:51       ` Sam Ravnborg
2015-03-23 21:08   ` Martin Walch
2015-03-23 21:24     ` Paul Bolle
2015-03-23 22:58       ` Martin Walch
2015-03-24  7:39         ` Jan Beulich
2015-03-24  7:38     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426164113.5304.54.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=JBeulich@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox