From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964853AbbCLQg2 (ORCPT ); Thu, 12 Mar 2015 12:36:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56422 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932489AbbCLQg0 (ORCPT ); Thu, 12 Mar 2015 12:36:26 -0400 Message-ID: <1426178182.3643.21.camel@redhat.com> Subject: Re: [PATCH kernel] vfio-pci: Add missing break to enable VFIO_PCI_ERR_IRQ_INDEX From: Alex Williamson To: Alexey Kardashevskiy Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Date: Thu, 12 Mar 2015 10:36:22 -0600 In-Reply-To: <1426131792-637-1-git-send-email-aik@ozlabs.ru> References: <1426131792-637-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-12 at 14:43 +1100, Alexey Kardashevskiy wrote: > This adds a missing break statement to VFIO_DEVICE_SET_IRQS handler > without which vfio_pci_set_err_trigger() would never be called. > > While we are here, add another "break" to VFIO_PCI_REQ_IRQ_INDEX case > so if we add more indexes later, we won't miss it. > > Signed-off-by: Alexey Kardashevskiy > --- > drivers/vfio/pci/vfio_pci_intrs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c > index f88bfdf..2027a27 100644 > --- a/drivers/vfio/pci/vfio_pci_intrs.c > +++ b/drivers/vfio/pci/vfio_pci_intrs.c > @@ -868,12 +868,14 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_device *vdev, uint32_t flags, > func = vfio_pci_set_err_trigger; > break; > } > + break; > case VFIO_PCI_REQ_IRQ_INDEX: > switch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) { > case VFIO_IRQ_SET_ACTION_TRIGGER: > func = vfio_pci_set_req_trigger; > break; > } > + break; > } > > if (!func) Whoops, that's no good. Added to my for-linus branch for v4.0. Thanks for the fix! Alex