From: Scott Wood <scottwood@freescale.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: <trivial@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>,
"USB list" <linux-usb@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers
Date: Thu, 12 Mar 2015 11:40:26 -0500 [thread overview]
Message-ID: <1426178426.30327.117.camel@freescale.com> (raw)
In-Reply-To: <CAOMZO5Bsr-5-ih3-t3pA=Aw-=SYOnwoc+6zve++R6Dx4xH91aw@mail.gmail.com>
On Thu, 2015-03-12 at 12:51 -0300, Fabio Estevam wrote:
> On Thu, Mar 12, 2015 at 12:13 AM, Scott Wood <scottwood@freescale.com> wrote:
> > Use %pS for actual addresses, otherwise you'll get bad output
> > on arches like ppc64 where %pF expects a function descriptor.
>
> From Documentation/printk-formats.txt:
>
> "On ia64, ppc64 and parisc64 architectures function pointers are
> actually function descriptors which must first be resolved. The 'F' and
> 'f' specifiers perform this resolution and then provide the same
> functionality as the 'S' and 's' specifiers."
>
> ,so current code should work fine on ppc64, right?
No. __builtin_return_address() returns a pointer to an instruction, not
a function pointer descriptor. If you use %pF on the former, it'll
print instruction opcodes as if they were the address.
-Scott
next prev parent reply other threads:[~2015-03-12 16:40 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 3:13 [PATCH 01/22] mm/memblock.c: %pF is only for function pointers Scott Wood
2015-03-12 3:13 ` [PATCH 02/22] netfilter: " Scott Wood
2015-03-12 3:13 ` [PATCH 03/22] sound: " Scott Wood
2015-03-12 3:13 ` [PATCH 04/22] md/bcache: " Scott Wood
2015-03-12 3:13 ` [PATCH 05/22] PM / AVS: SmartReflex: " Scott Wood
2015-03-12 18:09 ` Kevin Hilman
2015-03-12 18:14 ` Nishanth Menon
2015-03-12 18:16 ` Jiri Kosina
2015-03-12 3:13 ` [PATCH 06/22] random: " Scott Wood
2015-03-12 3:13 ` [PATCH 07/22] alpha: " Scott Wood
2015-03-12 3:13 ` [PATCH 08/22] ARM: " Scott Wood
2015-03-12 19:51 ` Russell King - ARM Linux
2015-03-12 3:13 ` [PATCH 09/22] blackfin: " Scott Wood
2015-03-12 3:13 ` [PATCH 10/22] microblaze: " Scott Wood
2015-03-12 3:13 ` [PATCH 11/22] powerpc/32: " Scott Wood
2015-03-12 3:13 ` [PATCH 12/22] sparc: " Scott Wood
2015-03-12 18:47 ` Sam Ravnborg
2015-03-12 18:49 ` Scott Wood
2015-03-12 18:54 ` Sam Ravnborg
2015-03-12 3:13 ` [PATCH 13/22] x86: " Scott Wood
2015-03-12 3:13 ` [PATCH 14/22] parisc: " Scott Wood
2015-03-12 12:11 ` James Bottomley
2015-03-12 14:43 ` John David Anglin
2015-03-12 16:14 ` Scott Wood
2015-03-12 18:04 ` James Bottomley
2015-03-12 19:48 ` Aaro Koskinen
2015-03-12 3:13 ` [PATCH 15/22] drm: " Scott Wood
2015-03-13 9:17 ` Daniel Vetter
2015-03-12 3:13 ` [PATCH 16/22] mfd: " Scott Wood
2015-03-12 9:03 ` Lee Jones
2015-03-12 3:13 ` [PATCH 17/22] esp_scsi: " Scott Wood
2015-03-12 11:23 ` Hannes Reinecke
2015-03-12 3:13 ` [PATCH 18/22] usb: gadget: serial: " Scott Wood
2015-03-12 4:45 ` Felipe Balbi
2015-03-12 5:27 ` Scott Wood
2015-03-12 15:38 ` Felipe Balbi
2015-03-12 12:36 ` Sergei Shtylyov
2015-03-12 16:43 ` Scott Wood
2015-03-12 15:51 ` Fabio Estevam
2015-03-12 16:40 ` Scott Wood [this message]
2015-03-12 16:43 ` Fabio Estevam
2015-03-12 3:13 ` [PATCH 19/22] jfs: " Scott Wood
2015-03-12 14:16 ` [Jfs-discussion] " Dave Kleikamp
2015-03-12 16:09 ` Scott Wood
2015-03-12 3:13 ` [PATCH 20/22] pstore: " Scott Wood
2015-06-16 22:02 ` Kees Cook
2015-06-16 22:37 ` Anton Vorontsov
2015-03-12 3:13 ` [PATCH 21/22] xfs: " Scott Wood
2015-08-31 8:06 ` Dave Chinner
2015-08-31 19:24 ` Scott Wood
2015-08-31 19:45 ` Steven Rostedt
2015-08-31 19:58 ` Scott Wood
2015-08-31 20:05 ` Steven Rostedt
2015-03-12 3:13 ` [PATCH 22/22] tracing: " Scott Wood
2015-03-12 20:23 ` Steven Rostedt
2015-03-12 20:25 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426178426.30327.117.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=balbi@ti.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox