From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755184AbbCLRah (ORCPT ); Thu, 12 Mar 2015 13:30:37 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:36867 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754002AbbCLRac (ORCPT ); Thu, 12 Mar 2015 13:30:32 -0400 From: Sudip Mukherjee To: Benjamin Romer , David Kershner , Greg Kroah-Hartman Cc: sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH v2 3/4] staging: unisys: remove comparison Date: Thu, 12 Mar 2015 23:00:11 +0530 Message-Id: <1426181412-19112-3-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1426181412-19112-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1426181412-19112-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org MAJOR(majordev) is 0 when dynamic major number is used, and it is greater than 0 when static major number is used. Considering both the cases the expression is always true. Signed-off-by: Sudip Mukherjee --- v2: changed commit log drivers/staging/unisys/visorchipset/file.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c index e9459af..e88a215 100644 --- a/drivers/staging/unisys/visorchipset/file.c +++ b/drivers/staging/unisys/visorchipset/file.c @@ -82,10 +82,8 @@ visorchipset_file_cleanup(void) cdev_del(&file_cdev); file_cdev.ops = NULL; if (registered) { - if (MAJOR(majordev) >= 0) { - unregister_chrdev_region(majordev, 1); - majordev = MKDEV(0, 0); - } + unregister_chrdev_region(majordev, 1); + majordev = MKDEV(0, 0); registered = FALSE; } } -- 1.8.1.2