linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Benjamin Romer <benjamin.romer@unisys.com>,
	David Kershner <david.kershner@unisys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: sparmaintainer@unisys.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH v2 4/4] staging: unisys: remove forward declarations
Date: Thu, 12 Mar 2015 23:00:12 +0530	[thread overview]
Message-ID: <1426181412-19112-4-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1426181412-19112-1-git-send-email-sudipm.mukherjee@gmail.com>

rearranged the functions to remove the forward declarations.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

v2: it was not in v1

 drivers/staging/unisys/visorchipset/file.c | 78 ++++++++++++++----------------
 1 file changed, 36 insertions(+), 42 deletions(-)

diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c
index e88a215..b74a0f2 100644
--- a/drivers/staging/unisys/visorchipset/file.c
+++ b/drivers/staging/unisys/visorchipset/file.c
@@ -33,48 +33,6 @@ static struct visorchannel **file_controlvm_channel;
 static dev_t majordev; /**< indicates major num for device */
 static BOOL registered = FALSE;
 
-static int visorchipset_open(struct inode *inode, struct file *file);
-static int visorchipset_release(struct inode *inode, struct file *file);
-static int visorchipset_mmap(struct file *file, struct vm_area_struct *vma);
-static long visorchipset_ioctl(struct file *file, unsigned int cmd,
-				unsigned long arg);
-
-static const struct file_operations visorchipset_fops = {
-	.owner = THIS_MODULE,
-	.open = visorchipset_open,
-	.read = NULL,
-	.write = NULL,
-	.unlocked_ioctl = visorchipset_ioctl,
-	.release = visorchipset_release,
-	.mmap = visorchipset_mmap,
-};
-
-int
-visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
-{
-	int rc = 0;
-
-	file_controlvm_channel = controlvm_channel;
-	majordev = major_dev;
-	cdev_init(&file_cdev, &visorchipset_fops);
-	file_cdev.owner = THIS_MODULE;
-	if (MAJOR(majordev) == 0) {
-		/* dynamic major device number registration required */
-		if (alloc_chrdev_region(&majordev, 0, 1, MYDRVNAME) < 0)
-			return -1;
-		registered = TRUE;
-	} else {
-		/* static major device number registration required */
-		if (register_chrdev_region(majordev, 1, MYDRVNAME) < 0)
-			return -1;
-		registered = TRUE;
-	}
-	rc = cdev_add(&file_cdev, MKDEV(MAJOR(majordev), 0), 1);
-	if (rc  < 0)
-		return -1;
-	return 0;
-}
-
 void
 visorchipset_file_cleanup(void)
 {
@@ -169,3 +127,39 @@ static long visorchipset_ioctl(struct file *file, unsigned int cmd,
 		return -EFAULT;
 	}
 }
+
+static const struct file_operations visorchipset_fops = {
+	.owner = THIS_MODULE,
+	.open = visorchipset_open,
+	.read = NULL,
+	.write = NULL,
+	.unlocked_ioctl = visorchipset_ioctl,
+	.release = visorchipset_release,
+	.mmap = visorchipset_mmap,
+};
+
+int
+visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
+{
+	int rc = 0;
+
+	file_controlvm_channel = controlvm_channel;
+	majordev = major_dev;
+	cdev_init(&file_cdev, &visorchipset_fops);
+	file_cdev.owner = THIS_MODULE;
+	if (MAJOR(majordev) == 0) {
+		/* dynamic major device number registration required */
+		if (alloc_chrdev_region(&majordev, 0, 1, MYDRVNAME) < 0)
+			return -1;
+		registered = TRUE;
+	} else {
+		/* static major device number registration required */
+		if (register_chrdev_region(majordev, 1, MYDRVNAME) < 0)
+			return -1;
+		registered = TRUE;
+	}
+	rc = cdev_add(&file_cdev, MKDEV(MAJOR(majordev), 0), 1);
+	if (rc  < 0)
+		return -1;
+	return 0;
+}
-- 
1.8.1.2


  parent reply	other threads:[~2015-03-12 17:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 17:30 [PATCH v2 1/4] staging: unisys: remove unused variables Sudip Mukherjee
2015-03-12 17:30 ` [PATCH v2 2/4] staging: unisys: dev_t initialization Sudip Mukherjee
2015-03-16 15:36   ` Greg Kroah-Hartman
2015-03-24  8:14     ` Dan Carpenter
2015-03-12 17:30 ` [PATCH v2 3/4] staging: unisys: remove comparison Sudip Mukherjee
2015-03-12 17:30 ` Sudip Mukherjee [this message]
2015-03-16 15:35 ` [PATCH v2 1/4] staging: unisys: remove unused variables Greg Kroah-Hartman
2015-03-17  7:21   ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426181412-19112-4-git-send-email-sudipm.mukherjee@gmail.com \
    --to=sudipm.mukherjee@gmail.com \
    --cc=benjamin.romer@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).