From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755935AbbCLWdQ (ORCPT ); Thu, 12 Mar 2015 18:33:16 -0400 Received: from smtprelay0175.hostedemail.com ([216.40.44.175]:33044 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751091AbbCLWdO (ORCPT ); Thu, 12 Mar 2015 18:33:14 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:69:355:379:541:599:973:982:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3871:3872:3874:4250:4321:4605:5007:7652:7903:10004:10400:10450:10455:10848:11026:11232:11473:11658:11914:12043:12294:12296:12517:12519:12683:12740:13069:13311:13357:14096:14097:19904:19999:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: thing15_561f8aa7d6554 X-Filterd-Recvd-Size: 2581 Message-ID: <1426199589.2742.16.camel@perches.com> Subject: Re: [PATCH 1/2] ACPI / EC: Cleanup logging/debugging splitter support. From: Joe Perches To: Lv Zheng Cc: "Rafael J. Wysocki" , Len Brown , Lv Zheng , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Date: Thu, 12 Mar 2015 15:33:09 -0700 In-Reply-To: <79307c846d7ca93d0423829b84cb0354e276fb73.1425019470.git.lv.zheng@intel.com> References: <79307c846d7ca93d0423829b84cb0354e276fb73.1425019470.git.lv.zheng@intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-02-27 at 14:48 +0800, Lv Zheng wrote: > This patch refines logging/debugging splitter support so that when DEBUG is > disabled, splitters won't be visible in the kernel logs while they are > still available for developers when DEBUG is enabled. > > This patch also refines the splitters to mark the following handling > process boundaries: > +++++: boundary of driver starting/stopping > boundary of IRQ storming > =====: boundary of transaction advancement > *****: boundary of EC command > boundary of EC query > #####: boundary of EC _Qxx evaluation trivia: > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c [] > /* -------------------------------------------------------------------------- > + * Logging/Debugging > + * -------------------------------------------------------------------------- */ > + > +/* > + * Splitters used by the developers to track the boundary of the EC > + * handling processes. > + */ It'd be nice to comment/document these 3 letter descriptions a bit better here in the source code. > +#ifdef DEBUG > +#define EC_DBG_SEP " " > +#define EC_DBG_DRV "+++++" > +#define EC_DBG_STM "=====" > +#define EC_DBG_REQ "*****" > +#define EC_DBG_EVT "#####" Maybe: #define EC_DBG_SEP " " #define EC_DBG_DRV "+++++" /* drivers start/stop */ #define EC_DBG_STM "=====" /* irq storm */ #define EC_DBG_REQ "*****" /* ec command boundary */ #define EC_DBG_EVT "#####" /* EC _Qxx evaluation */ >