From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756799AbbCMUm7 (ORCPT ); Fri, 13 Mar 2015 16:42:59 -0400 Received: from smtprelay0253.hostedemail.com ([216.40.44.253]:51155 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752543AbbCMUm5 (ORCPT ); Fri, 13 Mar 2015 16:42:57 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1042:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:4321:4384:4605:5007:6261:6742:7903:10004:10400:10848:11026:11232:11658:11914:12043:12438:12517:12519:12555:12740:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: cast77_3662f2f7f234c X-Filterd-Recvd-Size: 3346 Message-ID: <1426279372.11459.34.camel@perches.com> Subject: Re: [PATCH] checkpatch: catch all world writable debugfs_create_file From: Joe Perches To: Nicholas Mc Guire Cc: Andy Whitcroft , linux-kernel@vger.kernel.org, Ralf Baechle , Alexander Graf , Gleb Natapov , Paolo Bonzini , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Kalle Valo , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Steven Rostedt , Ingo Molnar Date: Fri, 13 Mar 2015 13:42:52 -0700 In-Reply-To: <1426274602-21196-1-git-send-email-hofrat@osadl.org> References: <1426274602-21196-1-git-send-email-hofrat@osadl.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-03-13 at 15:23 -0400, Nicholas Mc Guire wrote: > Currently checkpatch will fuss if one uses world writable settings in debugfs > files by passing S_IWUGO but not when passing S_IWOTH, S_IRWXUGO or S_IALLUGO. > This patch extends the check to catches all cases exporting world writable > files Maybe the debugfs_create_file should be debugfs_create_\w+ And there are also these octal matches: $ git grep -E -n "debugfs.*\b0[0-7][0-7][2367]" arch/mips/cavium-octeon/oct_ilm.c:75: show_dentry = debugfs_create_file("statistics", 0222, dir, NULL, arch/mips/cavium-octeon/oct_ilm.c:82: show_dentry = debugfs_create_file("reset", 0222, dir, NULL, arch/powerpc/kvm/timing.c:226: debugfs_file = debugfs_create_file(dbg_fname, 0666, drivers/misc/genwqe/card_debugfs.c:376: file = debugfs_create_x64("err_inject", 0666, root, &cd->err_inject); drivers/misc/genwqe/card_debugfs.c:382: file = debugfs_create_u32("ddcb_software_timeout", 0666, root, drivers/misc/genwqe/card_debugfs.c:389: file = debugfs_create_u32("kill_timeout", 0666, root, drivers/misc/genwqe/card_debugfs.c:461: file = debugfs_create_u32(name, 0666, root, drivers/misc/genwqe/card_debugfs.c:483: file = debugfs_create_u32("skip_recovery", 0666, root, drivers/misc/genwqe/card_debugfs.c:490: file = debugfs_create_u32("use_platform_recovery", 0666, root, drivers/net/wireless/mac80211_hwsim.c:2452: debugfs_create_file("ps", 0666, data->debugfs, data, &hwsim_fops_ps); drivers/net/wireless/mac80211_hwsim.c:2453: debugfs_create_file("group", 0666, data->debugfs, data, drivers/net/wireless/mac80211_hwsim.c:2456: debugfs_create_file("dfs_simulate_radar", 0222, drivers/power/axp288_fuel_gauge.c:333: info->debug_file = debugfs_create_file("fuelgauge", 0666, NULL, drivers/power/da9030_battery.c:191: charger->debug_file = debugfs_create_file("charger", 0666, NULL, kernel/trace/blktrace.c:499: bt->msg_file = debugfs_create_file("msg", 0222, dir, bt, &blk_msg_fops);