linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Ekstrand <jason@jlekstrand.net>
To: linux-kernel@vger.kernel.org
Cc: Jason Ekstrand <jason@jlekstrand.net>
Subject: RE: [PATCH] ACPI: Adjust the return value of _REV on x86
Date: Sat, 14 Mar 2015 12:58:51 -0700	[thread overview]
Message-ID: <1426363131-14530-1-git-send-email-jason.ekstrand@intel.com> (raw)
In-Reply-To: <1426150247-18309-1-git-send-email-matthew.garrett@nebula.com>

From: Jason Ekstrand <jason@jlekstrand.net>

On Wed, 11 Mar 2015 22:50:47, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> The ACPI spec describes _REV as:
> 
> "This predefined object evaluates to the revision of the ACPI Specification
>  that the specified \_OS implements"
> 
> We've been assuming that this should increment as ACPICA gains support for
> new versions of the spec. Unfortunately, Windows always reports "2" for this
> value and vendors are now using this as a means to tell whether a system is
> running Windows or Linux. From an HP Envy 15:
> 
> If (LOr (LEqual (_REV, 0x03), LEqual (_REV, 0x05)))
> 
> From a Dell XPS 13:
> 
> If ((_REV == 0x05))

I can confirm that on my 2015 Dell XPS 13, this patch fixes both the audio
and suspend/resume.  I'm running a build of Linus' master branch as of some
time this morning.  Without this patch applied I have no audio and suspend
fails leaving the system unresponsive but the keyboard light still on and
the fan running indefinitely.  With this patch, I get audio and
suspend/resume works normally.

--Jason Ekstrand

  reply	other threads:[~2015-03-14 19:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12  8:50 [PATCH] ACPI: Adjust the return value of _REV on x86 Matthew Garrett
2015-03-14 19:58 ` Jason Ekstrand [this message]
2015-03-16 23:21   ` Jason Ekstrand
2015-03-23 12:04     ` Matt Fleming
2015-03-24  5:50       ` Mario Limonciello
2015-03-24  9:17         ` Liam Girdwood
2015-03-24 14:41           ` Mario Limonciello
2015-03-24 15:24         ` Matt Fleming
2015-03-24 17:22           ` Mario Limonciello
2015-03-24 18:01             ` Matthew Garrett
2015-03-24 19:53               ` Mario Limonciello
2015-03-24 20:00                 ` Matthew Garrett
2015-03-24 20:02           ` Rafael J. Wysocki
2015-03-24 20:21             ` Mario Limonciello
2015-03-16 20:34 ` Al Stone
2015-03-16 21:01   ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426363131-14530-1-git-send-email-jason.ekstrand@intel.com \
    --to=jason@jlekstrand.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).