From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751838AbbCOCNP (ORCPT ); Sat, 14 Mar 2015 22:13:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43664 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751321AbbCOCNM (ORCPT ); Sat, 14 Mar 2015 22:13:12 -0400 Message-ID: <1426385580.28068.74.camel@stgolabs.net> Subject: Re: [PATCH 3/4] prctl: move MMF_EXE_FILE_CHANGED into exe_file struct From: Davidlohr Bueso To: akpm@linux-foundation.org Cc: viro@zeniv.linux.org.uk, gorcunov@openvz.org, oleg@redhat.com, koct9i@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Sat, 14 Mar 2015 19:13:00 -0700 In-Reply-To: <1426372766-3029-4-git-send-email-dave@stgolabs.net> References: <1426372766-3029-1-git-send-email-dave@stgolabs.net> <1426372766-3029-4-git-send-email-dave@stgolabs.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-03-14 at 15:39 -0700, Davidlohr Bueso wrote: > + if (test_and_set_mm_exe_file(mm, exefd.file)) > + return 0; > + return -EPERM; Bah, this is obviously bogus. We'd need the following folded in: diff --git a/kernel/sys.c b/kernel/sys.c index a82d0c4..41b27bd 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -1694,8 +1694,8 @@ set_file: * This grabs a reference to exefd.file. */ if (test_and_set_mm_exe_file(mm, exefd.file)) - return 0; - return -EPERM; + return -EPERM; + return 0; }