Re: [PATCH V1 3/3] accel/amdxdna: Set the system efficiency factor to 2

Mario Limonciello
2026-04-24T13:30:22Z

> From: Nishad Saraf <nishads@amd.com>
>
> The system efficiency factor is used for QoS calculation. Change it to 2
> to account for the efficiency overhead.
>
> Signed-off-by: Nishad Saraf <nishads@amd.com>
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
> drivers/accel/amdxdna/aie2_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/amdxdna/aie2_pci.c
> index a07e453a1721..f0ddb843eb21 100644
> --- a/drivers/accel/amdxdna/aie2_pci.c
> +++ b/drivers/accel/amdxdna/aie2_pci.c
> @@ -595,7 +595,7 @@ static int aie2_init(struct amdxdna_dev *xdna)
> xrs_cfg.clk_list.num_levels = ndev->max_dpm_level + 1;
> for (i = 0; i < xrs_cfg.clk_list.num_levels; i++)
> xrs_cfg.clk_list.cu_clk_list[i] = ndev->priv->dpm_clk_tbl[i].hclk;
> - xrs_cfg.sys_eff_factor = 1;
> + xrs_cfg.sys_eff_factor = 2;
> xrs_cfg.ddev = &xdna->ddev;
> xrs_cfg.actions = &aie2_xrs_actions;
> xrs_cfg.total_col = ndev->total_col;