From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753756AbbCPKQ1 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Mar 2015 06:16:27 -0400
Received: from cpsmtpb-ews06.kpnxchange.com ([213.75.39.9]:54269 "EHLO
	cpsmtpb-ews06.kpnxchange.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751221AbbCPKQX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Mar 2015 06:16:23 -0400
Message-ID: <1426500981.26437.24.camel@x220>
Subject: Re: [PATCH 2/2] rtc: add rtc-abx80x, a driver for the Abracon AB
 x80x i2c rtc
From: Paul Bolle <pebolle@tiscali.nl>
To: Philippe De Muyter <phdm@macqel.be>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Alessandro Zummo <a.zummo@towertech.it>, rtc-linux@googlegroups.com,
        linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Date: Mon, 16 Mar 2015 11:16:21 +0100
In-Reply-To: <20150314124441.GA11905@frolo.macqel>
References: <1426327546-8085-1-git-send-email-alexandre.belloni@free-electrons.com>
	 <1426327546-8085-3-git-send-email-alexandre.belloni@free-electrons.com>
	 <20150314124441.GA11905@frolo.macqel>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 16 Mar 2015 10:16:21.0978 (UTC) FILETIME=[404503A0:01D05FD2]
X-RcptDomain: vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2015-03-14 at 13:44 +0100, Philippe De Muyter wrote:
> On Sat, Mar 14, 2015 at 11:05:46AM +0100, Alexandre Belloni wrote:
> > --- /dev/null
> > +++ b/drivers/rtc/rtc-abx80x.c
> > +/*
> > + * A driver for the I2C members of the Abracon AB x8xx RTC family,
> > + * and compatible: AB 1805 and AB 0805
> > + *
> > + * Copyright 2014-2015 Macq S.A.
> > + *
> > + * Author: Philippe De Muyter <phdm@macqel.be>
> > + * Author: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + *
> > + */
> > 
> > +MODULE_LICENSE("GPL");
> 
> I'm fine with 'GPL', but someone suggested to change that to 'GPL v2' in my patch.

That someone was me. And my reasoning is that "GPL" is documented to
mean "GPL v2 or later", while "GPL v2" is documented to mean just that.
So "GPL v2" would match what is stated at the comment at the top of this
file.

Thanks,


Paul Bolle